len_without_is_empty improvements
#6980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
llogiq
reviewed
Mar 27, 2021
llogiq
reviewed
Mar 27, 2021
| } | ||
|
|
||
| impl LenOutput<'_> { | ||
| fn matches_is_empty_output(self, ty: Ty<'_>) -> bool { |
There was a problem hiding this comment.
That's a cool idea I hadn't even though of, to check if the output types match with either Option or Result. 👍
|
Just one possible improvement, otherwise this looks good to me. |
Check the return type of `len`. Only integral types, or an `Option` or `Result` wrapping one. Ensure the return type of `is_empty` matches. e.g. `Option<usize>` -> `Option<bool>`
Jarcho
force-pushed
the
len_without_is_empty_sig
branch
from
88bf10e
to
12985af
Compare
|
Thank you! @bors r+ |
|
📌 Commit 12985af has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Oh, thanks for fixing this quick. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6958
fixes: #6972
changelog: Check the return type of
len. Only integral types, or anOptionorResultwrapping one.changelog: Ensure the return type of
is_emptymatches. e.g.Option<usize>->Option<bool>