Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add match_str_case_mismatch lint #7806

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

Serial-ATA
Copy link
Contributor

changelog: Added a new lint [match_str_case_mismatch]

Fixes #7440

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 12, 2021
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to hide lines from docs with an initial # after the comment slashes. Then you can also run the tests. Also I'd add a suggestion to the lint.

clippy_lints/src/match_str_case_mismatch.rs Outdated Show resolved Hide resolved
clippy_lints/src/match_str_case_mismatch.rs Outdated Show resolved Hide resolved
clippy_lints/src/match_str_case_mismatch.rs Outdated Show resolved Hide resolved
@llogiq
Copy link
Contributor

llogiq commented Oct 12, 2021

Thank you! @bors r+

@bors
Copy link
Collaborator

bors commented Oct 12, 2021

📌 Commit 0c99de0 has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Oct 12, 2021

⌛ Testing commit 0c99de0 with merge d3905af...

@bors
Copy link
Collaborator

bors commented Oct 12, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing d3905af to master...

@bors bors merged commit d3905af into rust-lang:master Oct 12, 2021
@Serial-ATA Serial-ATA deleted the lint-match-case-mismatch branch October 12, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flag non-lowercase string literals in match expression on .to_lowercase()
4 participants