rust-lang · Manishearth · May 12, 2016 · May 12, 2016 · May 12, 2016
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,13 @@
 # Change Log
 All notable changes to this project will be documented in this file.
 
+## 0.0.67 — 2016-05-12
+* Rustup to *rustc 1.10.0-nightly (22ac88f1a 2016-05-11)*
+
+## 0.0.66 — 2016-05-11
+* New `cargo clippy` subcommand
+* New lints: [`assign_op_pattern`], [`assign_ops`], [`needless_borrow`]
+
 ## 0.0.65 — 2016-05-08
 * Rustup to *rustc 1.10.0-nightly (62e2b2fb7 2016-05-06)*
 * New lints: [`float_arithmetic`], [`integer_arithmetic`]

diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "clippy"
-version = "0.0.66"
+version = "0.0.67"
 authors = [
 	"Manish Goregaokar <manishsmail@gmail.com>",
 	"Andre Bogus <bogusandre@gmail.com>",

diff --git a/src/attrs.rs b/src/attrs.rs
@@ -130,7 +130,7 @@ fn is_relevant_expr(expr: &Expr) -> bool {
         ExprRet(None) | ExprBreak(_) => false,
         ExprCall(ref path_expr, _) => {
             if let ExprPath(_, ref path) = path_expr.node {
-                !match_path(path, &paths::BEGIN_UNWIND)
+                !match_path(path, &paths::BEGIN_PANIC)
             } else {
                 true
             }

diff --git a/src/cyclomatic_complexity.rs b/src/cyclomatic_complexity.rs
@@ -58,7 +58,7 @@ impl CyclomaticComplexity {
             divergence: 0,
             short_circuits: 0,
             returns: 0,
-            tcx: cx.tcx,
+            tcx: &cx.tcx,
         };
         helper.visit_block(block);
         let CCHelper { match_arms, divergence, short_circuits, returns, .. } = helper;
@@ -117,15 +117,15 @@ impl LateLintPass for CyclomaticComplexity {
     }
 }
 
-struct CCHelper<'a, 'tcx: 'a> {
+struct CCHelper<'a, 'gcx: 'a+'tcx, 'tcx: 'a> {
     match_arms: u64,
     divergence: u64,
     returns: u64,
     short_circuits: u64, // && and ||
-    tcx: &'a ty::TyCtxt<'tcx>,
+    tcx: &'a ty::TyCtxt<'a, 'gcx, 'tcx>,
 }
 
-impl<'a, 'b, 'tcx> Visitor<'a> for CCHelper<'b, 'tcx> {
+impl<'a, 'b, 'tcx, 'gcx> Visitor<'a> for CCHelper<'b, 'gcx, 'tcx> {
     fn visit_expr(&mut self, e: &'a Expr) {
         match e.node {
             ExprMatch(_, ref arms, _) => {

diff --git a/src/derive.rs b/src/derive.rs
@@ -86,15 +86,15 @@ impl LateLintPass for Derive {
 }
 
 /// Implementation of the `DERIVE_HASH_XOR_EQ` lint.
-fn check_hash_peq<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, span: Span, trait_ref: &TraitRef, ty: ty::Ty<'tcx>, hash_is_automatically_derived: bool) {
+fn check_hash_peq<'a, 'tcx: 'a>(cx: &LateContext<'a, 'tcx>, span: Span, trait_ref: &TraitRef, ty: ty::Ty<'tcx>, hash_is_automatically_derived: bool) {
     if_let_chain! {[
         match_path(&trait_ref.path, &paths::HASH),
         let Some(peq_trait_def_id) = cx.tcx.lang_items.eq_trait()
     ], {
         let peq_trait_def = cx.tcx.lookup_trait_def(peq_trait_def_id);
 
         // Look for the PartialEq implementations for `ty`
-        peq_trait_def.for_each_relevant_impl(&cx.tcx, ty, |impl_id| {
+        peq_trait_def.for_each_relevant_impl(cx.tcx, ty, |impl_id| {
             let peq_is_automatically_derived = cx.tcx.get_attrs(impl_id).iter().any(is_automatically_derived);
 
             if peq_is_automatically_derived == hash_is_automatically_derived {
@@ -131,9 +131,9 @@ fn check_hash_peq<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, span: Span, trait_ref: &
 fn check_copy_clone<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, item: &Item, trait_ref: &TraitRef, ty: ty::Ty<'tcx>) {
     if match_path(&trait_ref.path, &paths::CLONE_TRAIT) {
         let parameter_environment = ty::ParameterEnvironment::for_item(cx.tcx, item.id);
-        let subst_ty = ty.subst(cx.tcx, &parameter_environment.free_substs);
+        let subst_ty = ty.subst(cx.tcx, parameter_environment.free_substs);
 
-        if subst_ty.moves_by_default(&parameter_environment, item.span) {
+        if subst_ty.moves_by_default(cx.tcx.global_tcx(), &parameter_environment, item.span) {
             return; // ty is not Copy
         }
 

diff --git a/src/escape.rs b/src/escape.rs
@@ -1,11 +1,9 @@
 use rustc::hir::*;
 use rustc::hir::intravisit as visit;
 use rustc::hir::map::Node::{NodeExpr, NodeStmt};
-use rustc::infer;
 use rustc::lint::*;
 use rustc::middle::expr_use_visitor::*;
 use rustc::middle::mem_categorization::{cmt, Categorization};
-use rustc::traits::ProjectionMode;
 use rustc::ty::adjustment::AutoAdjustment;
 use rustc::ty;
 use rustc::util::nodemap::NodeSet;
@@ -42,7 +40,7 @@ fn is_non_trait_box(ty: ty::Ty) -> bool {
 }
 
 struct EscapeDelegate<'a, 'tcx: 'a> {
-    cx: &'a LateContext<'a, 'tcx>,
+    tcx: ty::TyCtxt<'a, 'tcx, 'tcx>,
     set: NodeSet,
 }
 
@@ -55,15 +53,18 @@ impl LintPass for EscapePass {
 impl LateLintPass for EscapePass {
     fn check_fn(&mut self, cx: &LateContext, _: visit::FnKind, decl: &FnDecl, body: &Block, _: Span, id: NodeId) {
         let param_env = ty::ParameterEnvironment::for_item(cx.tcx, id);
-        let infcx = infer::new_infer_ctxt(cx.tcx, &cx.tcx.tables, Some(param_env), ProjectionMode::Any);
+
+        let infcx = cx.tcx.borrowck_fake_infer_ctxt(param_env);
         let mut v = EscapeDelegate {
-            cx: cx,
+            tcx: cx.tcx,
             set: NodeSet(),
         };
+
         {
             let mut vis = ExprUseVisitor::new(&mut v, &infcx);
             vis.walk_fn(decl, body);
         }
+
         for node in v.set {
             span_lint(cx,
                       BOXED_LOCAL,
@@ -75,7 +76,6 @@ impl LateLintPass for EscapePass {
 
 impl<'a, 'tcx: 'a> Delegate<'tcx> for EscapeDelegate<'a, 'tcx> {
     fn consume(&mut self, _: NodeId, _: Span, cmt: cmt<'tcx>, mode: ConsumeMode) {
-
         if let Categorization::Local(lid) = cmt.cat {
             if self.set.contains(&lid) {
                 if let Move(DirectRefMove) = mode {
@@ -87,7 +87,7 @@ impl<'a, 'tcx: 'a> Delegate<'tcx> for EscapeDelegate<'a, 'tcx> {
     }
     fn matched_pat(&mut self, _: &Pat, _: cmt<'tcx>, _: MatchMode) {}
     fn consume_pat(&mut self, consume_pat: &Pat, cmt: cmt<'tcx>, _: ConsumeMode) {
-        let map = &self.cx.tcx.map;
+        let map = &self.tcx.map;
         if map.is_argument(consume_pat.id) {
             // Skip closure arguments
             if let Some(NodeExpr(..)) = map.find(map.get_parent_node(consume_pat.id)) {
@@ -132,8 +132,7 @@ impl<'a, 'tcx: 'a> Delegate<'tcx> for EscapeDelegate<'a, 'tcx> {
 
         if let Categorization::Local(lid) = cmt.cat {
             if self.set.contains(&lid) {
-                if let Some(&AutoAdjustment::AdjustDerefRef(adj)) = self.cx
-                                                                        .tcx
+                if let Some(&AutoAdjustment::AdjustDerefRef(adj)) = self.tcx
                                                                         .tables
                                                                         .borrow()
                                                                         .adjustments
@@ -148,13 +147,11 @@ impl<'a, 'tcx: 'a> Delegate<'tcx> for EscapeDelegate<'a, 'tcx> {
                     }
                 } else if LoanCause::AddrOf == loan_cause {
                     // &x
-                    if let Some(&AutoAdjustment::AdjustDerefRef(adj)) = self.cx
-                                                                            .tcx
+                    if let Some(&AutoAdjustment::AdjustDerefRef(adj)) = self.tcx
                                                                             .tables
                                                                             .borrow()
                                                                             .adjustments
-                                                                            .get(&self.cx
-                                                                                      .tcx
+                                                                            .get(&self.tcx
                                                                                       .map
                                                                                       .get_parent_node(borrow_id)) {
                         if adj.autoderefs <= 1 {

diff --git a/src/methods.rs b/src/methods.rs
@@ -560,7 +560,7 @@ fn lint_clone_on_copy(cx: &LateContext, expr: &Expr) {
     let parent = cx.tcx.map.get_parent(expr.id);
     let parameter_environment = ty::ParameterEnvironment::for_item(cx.tcx, parent);
 
-    if !ty.moves_by_default(&parameter_environment, expr.span) {
+    if !ty.moves_by_default(cx.tcx.global_tcx(), &parameter_environment, expr.span) {
         span_lint(cx, CLONE_ON_COPY, expr.span, "using `clone` on a `Copy` type");
     }
 }
@@ -1044,5 +1044,5 @@ fn is_bool(ty: &Ty) -> bool {
 
 fn is_copy<'a, 'ctx>(cx: &LateContext<'a, 'ctx>, ty: ty::Ty<'ctx>, item: &Item) -> bool {
     let env = ty::ParameterEnvironment::for_item(cx.tcx, item.id);
-    !ty.subst(cx.tcx, &env.free_substs).moves_by_default(&env, item.span)
+    !ty.subst(cx.tcx, env.free_substs).moves_by_default(cx.tcx.global_tcx(), &env, item.span)
 }
diff --git a/src/panic.rs b/src/panic.rs
@@ -33,7 +33,7 @@ impl LateLintPass for PanicPass {
             let ExprCall(ref fun, ref params) = ex.node,
             params.len() == 2,
             let ExprPath(None, ref path) = fun.node,
-            match_path(path, &paths::BEGIN_UNWIND),
+            match_path(path, &paths::BEGIN_PANIC),
             let ExprLit(ref lit) = params[0].node,
             is_direct_expn_of(cx, params[0].span, "panic").is_some(),
             let LitKind::Str(ref string, _) = lit.node,

diff --git a/src/types.rs b/src/types.rs
@@ -105,7 +105,7 @@ declare_lint! {
 fn check_let_unit(cx: &LateContext, decl: &Decl) {
     if let DeclLocal(ref local) = decl.node {
         let bindtype = &cx.tcx.pat_ty(&local.pat).sty;
-        if *bindtype == ty::TyTuple(vec![]) {
+        if *bindtype == ty::TyTuple(&[]) {
             if in_external_macro(cx, decl.span) || in_macro(cx, local.pat.span) {
                 return;
             }
@@ -162,7 +162,7 @@ impl LateLintPass for UnitCmp {
         if let ExprBinary(ref cmp, ref left, _) = expr.node {
             let op = cmp.node;
             let sty = &cx.tcx.expr_ty(left).sty;
-            if *sty == ty::TyTuple(vec![]) && op.is_comparison() {
+            if *sty == ty::TyTuple(&[]) && op.is_comparison() {
                 let result = match op {
                     BiEq | BiLe | BiGe => "true",
                     _ => "false",

diff --git a/src/utils/mod.rs b/src/utils/mod.rs
@@ -2,7 +2,6 @@ use reexport::*;
 use rustc::hir::*;
 use rustc::hir::def_id::DefId;
 use rustc::hir::map::Node;
-use rustc::infer;
 use rustc::lint::{LintContext, LateContext, Level, Lint};
 use rustc::middle::cstore;
 use rustc::session::Session;
@@ -274,15 +273,15 @@ pub fn implements_trait<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, ty: ty::Ty<'tcx>,
     cx.tcx.populate_implementations_for_trait_if_necessary(trait_id);
 
     let ty = cx.tcx.erase_regions(&ty);
-    let infcx = infer::new_infer_ctxt(cx.tcx, &cx.tcx.tables, None, ProjectionMode::Any);
-    let obligation = traits::predicate_for_trait_def(cx.tcx,
-                                                     traits::ObligationCause::dummy(),
-                                                     trait_id,
-                                                     0,
-                                                     ty,
-                                                     ty_params);
-
-    traits::SelectionContext::new(&infcx).evaluate_obligation_conservatively(&obligation)
+    cx.tcx.infer_ctxt(None, None, ProjectionMode::Any).enter(|infcx| {
+        let obligation = cx.tcx.predicate_for_trait_def(traits::ObligationCause::dummy(),
+                                                        trait_id,
+                                                        0,
+                                                        ty,
+                                                        ty_params);
+
+        traits::SelectionContext::new(&infcx).evaluate_obligation_conservatively(&obligation)
+    })
 }
 
 /// Match an `Expr` against a chain of methods, and return the matched `Expr`s.
@@ -795,7 +794,7 @@ pub fn unsugar_range(expr: &Expr) -> Option<UnsugaredRange> {
 /// Convenience function to get the return type of a function or `None` if the function diverges.
 pub fn return_ty<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, fn_item: NodeId) -> Option<ty::Ty<'tcx>> {
     let parameter_env = ty::ParameterEnvironment::for_item(cx.tcx, fn_item);
-    let fn_sig = cx.tcx.node_id_to_type(fn_item).fn_sig().subst(cx.tcx, &parameter_env.free_substs);
+    let fn_sig = cx.tcx.node_id_to_type(fn_item).fn_sig().subst(cx.tcx, parameter_env.free_substs);
     let fn_sig = cx.tcx.liberate_late_bound_regions(parameter_env.free_id_outlive, &fn_sig);
     if let ty::FnConverging(ret_ty) = fn_sig.output {
         Some(ret_ty)
@@ -809,10 +808,11 @@ pub fn return_ty<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, fn_item: NodeId) -> Optio
 // not for type parameters.
 pub fn same_tys<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, a: ty::Ty<'tcx>, b: ty::Ty<'tcx>, parameter_item: NodeId) -> bool {
     let parameter_env = ty::ParameterEnvironment::for_item(cx.tcx, parameter_item);
-    let infcx = infer::new_infer_ctxt(cx.tcx, &cx.tcx.tables, Some(parameter_env), ProjectionMode::Any);
-    let new_a = a.subst(infcx.tcx, &infcx.parameter_environment.free_substs);
-    let new_b = b.subst(infcx.tcx, &infcx.parameter_environment.free_substs);
-    infcx.can_equate(&new_a, &new_b).is_ok()
+    cx.tcx.infer_ctxt(None, Some(parameter_env), ProjectionMode::Any).enter(|infcx| {
+        let new_a = a.subst(infcx.tcx, infcx.parameter_environment.free_substs);
+        let new_b = b.subst(infcx.tcx, infcx.parameter_environment.free_substs);
+        infcx.can_equate(&new_a, &new_b).is_ok()
+    })
 }
 
 /// Recover the essential nodes of a desugared for loop:

diff --git a/src/utils/paths.rs b/src/utils/paths.rs
@@ -1,6 +1,6 @@
 //! This module contains paths to types and functions Clippy needs to know about.
 
-pub const BEGIN_UNWIND: [&'static str; 3] = ["std", "rt", "begin_unwind"];
+pub const BEGIN_PANIC: [&'static str; 3] = ["std", "rt", "begin_panic"];
 pub const BINARY_HEAP: [&'static str; 3] = ["collections", "binary_heap", "BinaryHeap"];
 pub const BOX: [&'static str; 3] = ["std", "boxed", "Box"];
 pub const BOX_NEW: [&'static str; 4] = ["std", "boxed", "Box", "new"];