Move let_underscore_drop to restriction
#9696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Alexendoo
force-pushed
the
let-underscore-drop
branch
from
08648d2 to
b495d09
Compare
flip1995
approved these changes
Oct 23, 2022
|
@bors r+ Thanks! |
bors
added a commit
that referenced
this pull request
Oct 23, 2022
Move `let_underscore_drop` to restriction Because of things like #9314. `let _` is considered the idiomatic way to ignore `must_use`: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attribute changelog: [`let_underscore_drop`]: move to restriction r? `@flip1995`
|
@bors r- I just remembered that this actually got uplifted, rust-lang/rust#97739, so I'll prepare a PR that does a rename instead |
|
Ah and it wasn't deprecated in Clippy. Yeah, please remove the lint from Clippy then. Now this is no longer our problem :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of things like #9314.
let _is considered the idiomatic way to ignoremust_use: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-must_use-attributechangelog: [
let_underscore_drop]: move to restrictionr? @flip1995