Mark let_underscore_lock and let_underscore_drop as uplifted
#9697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Alexendoo
force-pushed
the
let-underscore-uplift
branch
from
122a332 to
822f882
Compare
|
Should we limit the |
Alexendoo
force-pushed
the
let-underscore-uplift
branch
from
822f882 to
5dba80b
Compare
Alexendoo
force-pushed
the
let-underscore-uplift
branch
from
5dba80b to
9306540
Compare
|
Yeah I think that's a good plan |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
akoshelev
added a commit
to akoshelev/raw-ipa
that referenced
this pull request
Oct 27, 2022
Since yesterday, clippy seems unhappy with two `prss` tests with no obvious reason why.
```
error: non-binding `let` on a type that implements `Drop`
--> src/protocol/prss.rs:571:9
|
571 | let _ = p1.sequential(&step);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D clippy::let-underscore-drop` implied by `-D clippy::pedantic`
= help: consider using an underscore-prefixed named binding or dropping explicitly with `std::mem::drop`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_drop
```
It either sees what I don't see, but I wasn't able to find `Drop` implementation for that type. I also wasn't able to reproduce it locally neither on MacOS nor Linux, despite the fact that I am using the same cargo version as our GH action
```
~/workspace/raw-ipa% ~/.cargo/bin/cargo -V
cargo 1.64.0 (387270bc7 2022-09-16)
```
I wish I could learn clippy version as well, but reading the output did not reveal it.
There was a recent change in Clippy code that touched that lint: rust-lang/rust-clippy#9697 but I can't see how it could trigger this behaviour. To unblock us, lets appease Clippy for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I've renamed both the uplifted lints, however rustc's
let_underscore_lockis slightly less capable than the clippy lint as it doesn't catchparking_lottypes orResult<Guard, ..>, should we still remove it? TheResultchange looks like it was unintentional to me so that could probably be fixed upstreamchangelog: Uplift [
let_underscore_drop] to rustc rust-lang/rust#97739changelog: Remove overlap between rustc's
let_underscore_lockand Clippy's [let_underscore_lock]Closes #8003
Closes #9314
r? @flip1995