Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bastion): improve how to login into servers #764

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

MarcoIeni
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2024

r? @jdno

rustbot has assigned @jdno.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2024
Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions to ensure a consistent style, but the content is good. 👍

src/infra/docs/bastion.md Show resolved Hide resolved
src/infra/docs/bastion.md Outdated Show resolved Hide resolved
src/infra/docs/bastion.md Outdated Show resolved Hide resolved
src/infra/docs/bastion.md Outdated Show resolved Hide resolved
@MarcoIeni MarcoIeni force-pushed the docs-bastion-improve-how-to-login-into-servers branch from 29d6393 to f9caf05 Compare August 9, 2024 12:45
@MarcoIeni MarcoIeni requested a review from jdno August 9, 2024 12:46
Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MarcoIeni MarcoIeni merged commit ec1c6dc into master Aug 12, 2024
1 check passed
@MarcoIeni MarcoIeni deleted the docs-bastion-improve-how-to-login-into-servers branch August 12, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants