decrease false negatives for str overflow test

rust-lang · Apr 30, 2018 · 02b3da1 · 02b3da1
1 parent ce66f5d
commit 02b3da1
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/liballoc/tests/str.rs b/src/liballoc/tests/str.rs
@@ -602,7 +602,9 @@ mod slice_index {
             mod rangeinclusive {
                 let DATA = "hello";
 
-                let BAD_INPUT = 1..=usize::max_value();
+                // note: using 0 specifically ensures that the result of overflowing is 0..0,
+                //       so that `get` doesn't simply return None for the wrong reason.
+                let BAD_INPUT = 0..=usize::max_value();
                 const EXPECT_MSG = "maximum usize";
 
                 !!generate_tests!!