Skip to content

Commit

Permalink
Allow bare CR in ////-style comment.
Browse files Browse the repository at this point in the history
  • Loading branch information
qnighy committed May 8, 2017
1 parent 70198a0 commit 0e8e45c
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/libsyntax/parse/lexer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ impl<'a> StringReader<'a> {
self.bump();

// line comments starting with "///" or "//!" are doc-comments
let doc_comment = self.ch_is('/') || self.ch_is('!');
let doc_comment = (self.ch_is('/') && !self.nextch_is('/')) || self.ch_is('!');
let start_bpos = self.pos - BytePos(2);

while !self.is_eof() {
Expand Down
6 changes: 6 additions & 0 deletions src/test/parse-fail/lex-bare-cr-string-literal-doc-comment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ pub fn bar() {}
//~^^ ERROR: bare CR not allowed in block doc-comment

fn main() {
//! doc comment with bare CR: ''
//~^ ERROR: bare CR not allowed in doc-comment

/*! block doc comment with bare CR: '' */
//~^ ERROR: bare CR not allowed in block doc-comment

// the following string literal has a bare CR in it
let _s = "foobar"; //~ ERROR: bare CR not allowed in string

Expand Down
18 changes: 18 additions & 0 deletions src/test/run-pass/lex-bare-cr-nondoc-comment.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-tidy-cr

// nondoc comment with bare CR: ''
//// nondoc comment with bare CR: ''
/* block nondoc comment with bare CR: '' */

fn main() {
}
Expand Down

0 comments on commit 0e8e45c

Please sign in to comment.