Skip to content

Commit

Permalink
Add tests for the parsing of + and the error messages if people get…
Browse files Browse the repository at this point in the history
… it wrong.

Fixes #18772.
  • Loading branch information
nikomatsakis committed Nov 26, 2014
1 parent 1479a90 commit 21d5d13
Show file tree
Hide file tree
Showing 3 changed files with 83 additions and 0 deletions.
35 changes: 35 additions & 0 deletions src/test/compile-fail/hrtb-precedence-of-plus-error-message.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(unboxed_closures)]

// Test that we suggest the correct parentheses

trait Bar {
fn dummy(&self) { }
}

struct Foo<'a> {
a: &'a Bar+'a,
//~^ ERROR E0171
//~^^ NOTE perhaps you meant `&'a (Bar + 'a)`?

b: &'a mut Bar+'a,
//~^ ERROR E0171
//~^^ NOTE perhaps you meant `&'a mut (Bar + 'a)`?

c: Box<Bar+'a>, // OK, no paren needed in this context

d: fn() -> Bar+'a,
//~^ ERROR E0171
//~^^ NOTE perhaps you forgot parentheses
}

fn main() { }
27 changes: 27 additions & 0 deletions src/test/run-pass/hrtb-precedence-of-plus-where-clause.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(unboxed_closures)]

// Test that `F : Fn(int) -> int + Send` is interpreted as two
// distinct bounds on `F`.

fn foo<F>(f: F)
where F : FnOnce(int) -> int + Send
{
bar(f);
baz(f);
}

fn bar<F:Send>(f: F) { }

fn baz<F:FnOnce(int) -> int>(f: F) { }

fn main() {}
21 changes: 21 additions & 0 deletions src/test/run-pass/hrtb-precedence-of-plus.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

#![feature(unboxed_closures)]

// Test that `Fn(int) -> int + 'static` parses as `(Fn(int) -> int) +
// 'static` and not `Fn(int) -> (int + 'static)`. The latter would
// cause a compilation error. Issue #18772.

fn adder(y: int) -> Box<Fn(int) -> int + 'static> {
box move |&: x| y + x
}

fn main() {}

1 comment on commit 21d5d13

@nikomatsakis
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=brson

Please sign in to comment.