Skip to content

Commit

Permalink
remove resolved fixmes
Browse files Browse the repository at this point in the history
  • Loading branch information
zeegomo committed Jan 10, 2023
1 parent 1c1e795 commit 25cf2b6
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 30 deletions.
4 changes: 0 additions & 4 deletions compiler/rustc_borrowck/src/used_muts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,6 @@ impl<'visit, 'cx, 'tcx> Visitor<'tcx> for GatherUsedMutsVisitor<'visit, 'cx, 'tc
TerminatorKind::Call { destination, .. } => {
self.remove_never_initialized_mut_locals(*destination);
}
// FIXME: ??
// TerminatorKind::DropAndReplace { place, .. } => {
// self.remove_never_initialized_mut_locals(*place);
// }
_ => {}
}

Expand Down
13 changes: 0 additions & 13 deletions compiler/rustc_const_eval/src/transform/check_consts/resolver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -222,19 +222,6 @@ where
// The effect of assignment to the return place in `TerminatorKind::Call` is not applied
// here; that occurs in `apply_call_return_effect`.

// FIXME ??
// if let mir::TerminatorKind::DropAndReplace { value, place, .. } = &terminator.kind {
// let qualif = qualifs::in_operand::<Q, _>(
// self.ccx,
// &mut |l| self.state.qualif.contains(l),
// value,
// );

// if !place.is_indirect() {
// self.assign_qualif_direct(place, qualif);
// }
// }

// We ignore borrow on drop because custom drop impls are not allowed in consts.
// FIXME: Reconsider if accounting for borrows in drops is necessary for const drop.

Expand Down
13 changes: 0 additions & 13 deletions compiler/rustc_const_eval/src/transform/validate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -736,19 +736,6 @@ impl<'a, 'tcx> Visitor<'tcx> for TypeChecker<'a, 'tcx> {
self.check_edge(location, *unwind, EdgeKind::Unwind);
}
}
// FIXME ??
// TerminatorKind::DropAndReplace { target, unwind, .. } => {
// if self.mir_phase >= MirPhase::Runtime(RuntimePhase::Initial) {
// self.fail(
// location,
// "`DropAndReplace` should have been removed during drop elaboration",
// );
// }
// self.check_edge(location, *target, EdgeKind::Normal);
// if let Some(unwind) = unwind {
// self.check_edge(location, *unwind, EdgeKind::Unwind);
// }
// }
TerminatorKind::Call { func, args, destination, target, cleanup, .. } => {
let func_ty = func.ty(&self.body.local_decls, self.tcx);
match func_ty.kind() {
Expand Down

0 comments on commit 25cf2b6

Please sign in to comment.