-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
coverage: Register
test::Coverage
as the test suite for `tests/cove…
…rage` This restores the ability to run a coverage test by specifying its path, e.g. `./x.py test tests/coverage/if.rs`. This runs the test in both modes.
- Loading branch information
Showing
2 changed files
with
12 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,16 @@ | ||
Many of these tests were copied from `tests/run-coverage` in order to | ||
capture the current behavior of the instrumentor on non-trivial programs. | ||
The actual mappings have not been closely inspected. | ||
The tests in this directory are shared by two different test modes, and can be | ||
run in multiple different ways: | ||
|
||
- `./x.py test coverage-map` (compiles to LLVM IR and checks coverage mappings) | ||
- `./x.py test run-coverage` (runs a test binary and checks its coverage report) | ||
- `./x.py test coverage` (runs both `coverage-map` and `run-coverage`) | ||
|
||
## Maintenance note | ||
|
||
These tests can be sensitive to small changes in MIR spans or MIR control flow, | ||
especially in HIR-to-MIR lowering or MIR optimizations. | ||
|
||
If you haven't touched the coverage code directly, and the `run-coverage` test | ||
suite still works, then it should usually be OK to just `--bless` these | ||
coverage mapping tests as necessary, without worrying too much about the exact | ||
changes. | ||
If you haven't touched the coverage code directly, and the tests still pass in | ||
`run-coverage` mode, then it should usually be OK to just re-bless the mappings | ||
as necessary with `./x.py test coverage-map --bless`, without worrying too much | ||
about the exact changes. |