Rewrite lto-readonly-lib to rmake

src/tools/tidy/src/allowed_run_make_makefiles.txt

@@ -129,7 +129,6 @@ run-make/lto-dylib-dep/Makefile
 run-make/lto-empty/Makefile
 run-make/lto-linkage-used-attr/Makefile
 run-make/lto-no-link-whole-rlib/Makefile
-run-make/lto-readonly-lib/Makefile
 run-make/lto-smoke-c/Makefile
 run-make/macos-deployment-target/Makefile
 run-make/macos-fat-archive/Makefile

tests/run-make/ls-metadata/rmake.rs

@@ -10,8 +10,8 @@ use run_make_support::fs_wrapper;
 use run_make_support::{rmake_out_path, rustc};
 
 fn main() {
-    rustc().input("foo.rs");
-    rustc().arg("-Zls=root").input(rmake_out_path("foo"));
+    rustc().input("foo.rs").run();
+    rustc().arg("-Zls=root").input(rmake_out_path("foo")).run();
     fs_wrapper::create_file(rmake_out_path("bar"));
-    rustc().arg("-Zls=root").input(rmake_out_path("bar"));
+    rustc().arg("-Zls=root").input(rmake_out_path("bar")).run();
 }

tests/run-make/lto-readonly-lib/rmake.rs

@@ -0,0 +1,25 @@
+// When the compiler is performing link time optimization, it will
+// need to copy the original rlib file, set the copy's permissions to read/write,
+// and modify that copy - even if the original
+// file is read-only. This test creates a read-only rlib, and checks that
+// compilation with LTO succeeds.
+// See https://github.com/rust-lang/rust/pull/17619
+
+//@ ignore-cross-compile
+
+use run_make_support::fs_wrapper;
+use run_make_support::{rmake_out_dir, run, rustc};
+
+fn main() {
+    rustc().input("lib.rs").run();
+    let entries = fs_wrapper::read_dir(rmake_out_dir());
+    for entry in entries {
+        if entry.path().extension().and_then(|s| s.to_str()) == Some("rlib") {
+            let mut perms = fs_wrapper::metadata(entry.path()).permissions();
+            perms.set_readonly(true);
+            fs_wrapper::set_permissions(entry.path(), perms);
+        }
+    }
+    rustc().input("main.rs").arg("-Clto").run();
+    run("main");
+}