Added panics for unreachable states for expectations (RFC 2383)

rust-lang · Mar 2, 2022 · 4887eb7 · 4887eb7
1 parent 3414ad9
commit 4887eb7
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/compiler/rustc_errors/src/lib.rs b/compiler/rustc_errors/src/lib.rs
@@ -942,18 +942,22 @@ impl Handler {
 
         let mut inner = self.inner.borrow_mut();
         for mut diag in diags.into_iter() {
-            if let Some(mut unstable_id) = diag.level.get_expectation_id() {
-                let lint_index = unstable_id.get_lint_index();
-
-                // The unstable to stable map only maps the unstable it to a stable id
-                // the lint index is manually transferred here.
-                unstable_id.set_lint_index(None);
-                if let Some(mut stable_id) = unstable_to_stable.get(&unstable_id).map(|id| *id) {
-                    stable_id.set_lint_index(lint_index);
-                    diag.level = Level::Expect(stable_id);
-                    inner.fulfilled_expectations.insert(stable_id);
-                }
-            }
+            let mut unstable_id = diag
+                .level
+                .get_expectation_id()
+                .expect("all diagnostics inside `unstable_expect_diagnostics` must have a `LintExpectationId`");
+
+            // The unstable to stable map only maps the unstable it to a stable id
+            // the lint index is manually transferred here.
+            let lint_index = unstable_id.get_lint_index();
+            unstable_id.set_lint_index(None);
+            let mut stable_id = *unstable_to_stable
+                .get(&unstable_id)
+                .expect("each unstable `LintExpectationId` must have a matching stable id");
+
+            stable_id.set_lint_index(lint_index);
+            diag.level = Level::Expect(stable_id);
+            inner.fulfilled_expectations.insert(stable_id);
 
             (*TRACK_DIAGNOSTICS)(&diag);
         }

diff --git a/compiler/rustc_lint/src/expect.rs b/compiler/rustc_lint/src/expect.rs
@@ -20,6 +20,8 @@ pub fn check_expectations(tcx: TyCtxt<'_>) {
             // holds stable ids
             if let LintExpectationId::Stable { hir_id, .. } = id {
                 emit_unfulfilled_expectation_lint(tcx, *hir_id, expectation);
+            } else {
+                unreachable!("at this stage all `LintExpectationId`s are stable");
             }
         }
     }