Skip to content

Commit

Permalink
Add rustfix test for unsafe extern blocks
Browse files Browse the repository at this point in the history
  • Loading branch information
spastorino committed Jun 5, 2024
1 parent be0726c commit 525828d
Show file tree
Hide file tree
Showing 3 changed files with 63 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//@ run-rustfix

#![feature(unsafe_extern_blocks)]
#![deny(missing_unsafe_on_extern)]
#![allow(unused)]

unsafe extern "C" {
//~^ ERROR extern blocks should be unsafe [missing_unsafe_on_extern]
//~| WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2024!
static TEST1: i32;
fn test1(i: i32);
}

unsafe extern "C" {
static TEST2: i32;
fn test2(i: i32);
}

fn main() {}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//@ run-rustfix

#![feature(unsafe_extern_blocks)]
#![deny(missing_unsafe_on_extern)]
#![allow(unused)]

extern "C" {
//~^ ERROR extern blocks should be unsafe [missing_unsafe_on_extern]
//~| WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2024!
static TEST1: i32;
fn test1(i: i32);
}

unsafe extern "C" {
static TEST2: i32;
fn test2(i: i32);
}

fn main() {}
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
error: extern blocks should be unsafe
--> $DIR/unsafe-extern-suggestion.rs:7:1
|
LL | extern "C" {
| ^
| |
| _help: needs `unsafe` before the extern keyword: `unsafe`
| |
LL | |
LL | |
LL | | static TEST1: i32;
LL | | fn test1(i: i32);
LL | | }
| |_^
|
= warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2024!
= note: for more information, see issue #123743 <https://github.com/rust-lang/rust/issues/123743>
note: the lint level is defined here
--> $DIR/unsafe-extern-suggestion.rs:4:9
|
LL | #![deny(missing_unsafe_on_extern)]
| ^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to 1 previous error

0 comments on commit 525828d

Please sign in to comment.