Skip to content

Commit

Permalink
More test fixes and rebase conflicts!
Browse files Browse the repository at this point in the history
  • Loading branch information
alexcrichton committed Nov 27, 2014
1 parent e8d743e commit 5816d7f
Show file tree
Hide file tree
Showing 9 changed files with 128 additions and 119 deletions.
2 changes: 1 addition & 1 deletion src/libcollections/binary_heap.rs
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ impl<'a, T> DoubleEndedIterator<&'a T> for Items<'a, T> {
fn next_back(&mut self) -> Option<(&'a T)> { self.iter.next_back() }
}

impl<'a, T> ExactSize<&'a T> for Items<'a, T> {}
impl<'a, T> ExactSizeIterator<&'a T> for Items<'a, T> {}

/// An iterator that moves out of a `BinaryHeap`.
pub struct MoveItems<T> {
Expand Down
2 changes: 1 addition & 1 deletion src/libcollections/ring_buf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,7 @@ impl<T> DoubleEndedIterator<T> for MoveItems<T> {
}


impl<T> ExactSize<T> for MoveItems<T> {}
impl<T> ExactSizeIterator<T> for MoveItems<T> {}

impl<A: PartialEq> PartialEq for RingBuf<A> {
fn eq(&self, other: &RingBuf<A>) -> bool {
Expand Down
3 changes: 2 additions & 1 deletion src/librustc/diagnostics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,5 +147,6 @@ register_diagnostics!(
E0168,
E0169,
E0170,
E0171
E0171,
E0172
)
25 changes: 13 additions & 12 deletions src/librustc/middle/traits/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,19 @@ pub fn supertraits<'cx, 'tcx>(tcx: &'cx ty::ctxt<'tcx>,
trait_ref: Rc<ty::TraitRef<'tcx>>)
-> Supertraits<'cx, 'tcx>
{
/// Returns an iterator over the trait reference `T` and all of its supertrait references. May
/// contain duplicates. In general the ordering is not defined.
///
/// Example:
///
/// ```
/// trait Foo { ... }
/// trait Bar : Foo { ... }
/// trait Baz : Bar+Foo { ... }
/// ```
///
/// `supertraits(Baz)` yields `[Baz, Bar, Foo, Foo]` in some order.
//! Returns an iterator over the trait reference `T` and all of its supertrait references. May
//! contain duplicates. In general the ordering is not defined.
//!
//! Example:
//!
//! ```
//! trait Foo { ... }
//! trait Bar : Foo { ... }
//! trait Baz : Bar+Foo { ... }
//! ```
//!
//! `supertraits(Baz)` yields `[Baz, Bar, Foo, Foo]` in some order.
transitive_bounds(tcx, &[trait_ref])
}

Expand Down
2 changes: 1 addition & 1 deletion src/librustc/middle/typeck/astconv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@ fn ast_ty_to_trait_ref<'tcx,AC,RS>(this: &AC,
path));
}
_ => {
span_err!(this.tcx().sess, ty.span, E0170, "expected a reference to a trait");
span_err!(this.tcx().sess, ty.span, E0172, "expected a reference to a trait");
Err(ErrorReported)
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/librustc/middle/typeck/check/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1252,8 +1252,6 @@ fn compare_impl_method<'tcx>(tcx: &ty::ctxt<'tcx>,
-> bool
{

*/

let trait_params = trait_generics.regions.get_slice(subst::FnSpace);
let impl_params = impl_generics.regions.get_slice(subst::FnSpace);

Expand Down
2 changes: 1 addition & 1 deletion src/librustc_trans/trans/datum.rs
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ impl<'tcx, K: KindOps + fmt::Show> Datum<'tcx, K> {
self.kind)
}

//! See the `appropriate_rvalue_mode()` function
/// See the `appropriate_rvalue_mode()` function
pub fn appropriate_rvalue_mode<'a>(&self, ccx: &CrateContext<'a, 'tcx>)
-> RvalueMode {
appropriate_rvalue_mode(ccx, self.ty)
Expand Down
207 changes: 108 additions & 99 deletions src/libstd/fmt.rs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/libterm/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ pub fn stderr() -> Option<Box<Terminal<WriterWrapper> + Send>> {
#[cfg(windows)]
/// Return a Terminal wrapping stderr, or None if a terminal couldn't be
/// opened.
pub fn stderr() -> Option<Box<Terminal<WriterWrapper> + Send> + Send> {
pub fn stderr() -> Option<Box<Terminal<WriterWrapper> + Send>> {
let ti = TerminfoTerminal::new(WriterWrapper {
wrapped: box std::io::stderr() as Box<Writer + Send>,
});
Expand Down

9 comments on commit 5816d7f

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at alexcrichton@5816d7f

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging alexcrichton/rust/rollup = 5816d7f into auto

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexcrichton/rust/rollup = 5816d7f merged ok, testing candidate = 74363ad2

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from alexcrichton
at alexcrichton@5816d7f

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging alexcrichton/rust/rollup = 5816d7f into auto

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexcrichton/rust/rollup = 5816d7f merged ok, testing candidate = f358ca4

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on 5816d7f Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = f358ca4

Please sign in to comment.