-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In regards to: #19253 (comment) This commit: * Changes the #deriving code so that it generates code that utilizes fewer reexports (in particur Option::* and Result::*), which is necessary to remove those reexports in the future * Changes other areas of the codebase so that fewer reexports are utilized
- Loading branch information
Showing
85 changed files
with
277 additions
and
195 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from sfackler
at frewsxcv@6614476
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging frewsxcv/rust/rm-reexports = 6614476 into auto
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frewsxcv/rust/rm-reexports = 6614476 merged ok, testing candidate = d253f351
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2502
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2505
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2495
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2502
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2496
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2495
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2495
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2499
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2492
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2491
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2494
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2156
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2152
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/989
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from sfackler
at frewsxcv@6614476
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging frewsxcv/rust/rm-reexports = 6614476 into auto
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frewsxcv/rust/rm-reexports = 6614476 merged ok, testing candidate = 24adc98
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2503
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2506
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2496
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2503
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2497
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2496
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2496
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2500
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2493
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2492
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2495
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2153
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from sfackler
at frewsxcv@6614476
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging frewsxcv/rust/rm-reexports = 6614476 into auto
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
frewsxcv/rust/rm-reexports = 6614476 merged ok, testing candidate = 0d6adc59
6614476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
failure: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2504
exception: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2507
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/2497
exception: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/2504
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2498
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/2497
exception: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/2497
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2501
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/2494
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/2493
exception: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/2496
exception: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2158
exception: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/2154
exception: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/997
exception: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/987