Skip to content

Commit

Permalink
Re-enable debuginfo tests that have been ignored
Browse files Browse the repository at this point in the history
Most of these tests either ran perfectly once enabled or only needed a
small amount of tweaking to get passing or used ignore-test when
ignore-lldb would have been more appropriate.

With this change we go from 64 ignored tests to 50.
  • Loading branch information
wesleywiser committed Mar 2, 2022
1 parent f0c4da4 commit 78e7d9b
Show file tree
Hide file tree
Showing 12 changed files with 3 additions and 16 deletions.
3 changes: 1 addition & 2 deletions src/test/debuginfo/basic-types-globals-metadata.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// min-lldb-version: 310
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155

// compile-flags:-g
// gdb-command:run
Expand All @@ -11,7 +10,7 @@
// gdb-check:type = isize
// gdbg-command:whatis 'basic_types_globals_metadata::C'
// gdbr-command:whatis basic_types_globals_metadata::C
// gdb-check:type = char
// gdb-check:type = char32_t
// gdbg-command:whatis 'basic_types_globals_metadata::I8'
// gdbr-command:whatis basic_types_globals_metadata::I8
// gdb-check:type = i8
Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/c-style-enum.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// ignore-aarch64
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
// min-lldb-version: 310

// compile-flags:-g
Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/cross-crate-spans.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

// This fails on lldb 6.0.1 on x86-64 Fedora 28; so mark it macOS-only
// for now.
// only-macos

// aux-build:cross_crate_spans.rs
extern crate cross_crate_spans;
Expand Down
4 changes: 0 additions & 4 deletions src/test/debuginfo/destructured-for-loop-variable.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
// min-lldb-version: 310

// This fails on lldb 6.0.1 on x86-64 Fedora 28; so mark it macOS-only
// for now.
// only-macos

// compile-flags:-g

// === GDB TESTS ===================================================================================
Expand Down
2 changes: 1 addition & 1 deletion src/test/debuginfo/function-arg-initialization.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// ignore-test // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
// ignore-lldb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
// min-lldb-version: 310

// This test case checks if function arguments already have the correct value
Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/lexical-scopes-in-block-expression.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// min-lldb-version: 310
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155

// compile-flags:-g

Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/limited-debuginfo.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// ignore-lldb
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155

// compile-flags:-C debuginfo=1

Expand Down
2 changes: 1 addition & 1 deletion src/test/debuginfo/method-on-enum.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// min-lldb-version: 310
// ignore-test // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155
// ignore-lldb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155

// compile-flags:-g

Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/simple-struct.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// min-lldb-version: 310
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155

// compile-flags:-g

Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/simple-tuple.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// min-lldb-version: 310
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155

// compile-flags:-g

Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/union-smoke.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// min-lldb-version: 310
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155

// ignore-gdb-version: 7.11.90 - 7.12.9

Expand Down
1 change: 0 additions & 1 deletion src/test/debuginfo/vec.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// min-lldb-version: 310
// ignore-gdb // Test temporarily ignored due to debuginfo tests being disabled, see PR 47155

// compile-flags:-g

Expand Down

0 comments on commit 78e7d9b

Please sign in to comment.