Skip to content

Commit

Permalink
Remove individual crate checks for bootstrap in tidy
Browse files Browse the repository at this point in the history
This duplicates a lot of checking, and doesn't seem particularly useful -
these are already caught in review.

Note that this still keeps the license check.
  • Loading branch information
jyn514 committed Jun 22, 2022
1 parent 345eb14 commit 81482e6
Showing 1 changed file with 0 additions and 83 deletions.
83 changes: 0 additions & 83 deletions src/tools/tidy/src/deps.rs
Original file line number Diff line number Diff line change
Expand Up @@ -293,82 +293,6 @@ const PERMITTED_CRANELIFT_DEPENDENCIES: &[&str] = &[
"winapi-x86_64-pc-windows-gnu",
];

const PERMITTED_BOOTSTRAP_DEPENDENCIES: &[&str] = &[
"aho-corasick",
"autocfg",
"ansi_term",
"block-buffer",
"bitflags",
"bstr",
"core-foundation-sys",
"cc",
"cfg-if",
"crossbeam-utils",
"cmake",
"cpufeatures",
"crossbeam-channel",
"crossbeam-deque",
"crossbeam-epoch",
"crypto-common",
"ctor",
"diff",
"digest",
"either",
"filetime",
"fnv",
"getopts",
"generic-array",
"globset",
"hermit-abi",
"hex",
"ignore",
"itoa",
"lazy_static",
"libc",
"log",
"lzma-sys",
"memchr",
"memoffset",
"ntapi",
"num_cpus",
"once_cell",
"opener",
"output_vt100",
"pkg-config",
"pretty_assertions",
"proc-macro2",
"quote",
"rayon",
"rayon-core",
"redox_syscall",
"regex",
"regex-automata",
"regex-syntax",
"ryu",
"same-file",
"scopeguard",
"serde",
"serde_derive",
"serde_json",
"sha2",
"syn",
"sysinfo",
"tar",
"thread_local",
"toml",
"typenum",
"unicode-ident",
"unicode-width",
"version_check",
"walkdir",
"winapi",
"winapi-i686-pc-windows-gnu",
"winapi-util",
"winapi-x86_64-pc-windows-gnu",
"xattr",
"xz2",
];

const FORBIDDEN_TO_HAVE_DUPLICATES: &[&str] = &[
// These two crates take quite a long time to build, so don't allow two versions of them
// to accidentally sneak into our dependency graph, in order to ensure we keep our CI times
Expand Down Expand Up @@ -422,13 +346,6 @@ pub fn check(root: &Path, cargo: &Path, bad: &mut bool) {
let metadata = t!(cmd.exec());
let runtime_ids = HashSet::new();
check_exceptions(&metadata, EXCEPTIONS_BOOTSTRAP, runtime_ids, bad);
check_dependencies(
&metadata,
"bootstrap",
PERMITTED_BOOTSTRAP_DEPENDENCIES,
&["bootstrap"],
bad,
);
}

/// Check that all licenses are in the valid list in `LICENSES`.
Expand Down

0 comments on commit 81482e6

Please sign in to comment.