Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rustdoc: make calls of markdown::render safer
Previously, external code might call `markdown::render()` without having called `markdown::reset_headers()`, meaning the TLS key `used_header_map` was unset. Now `markdown::render()` ensures that `used_header_map` is set by calling `reset_headers` if necessary. Fix #17736
- Loading branch information
942bed7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from alexcrichton
at tomjakubowski@942bed7
942bed7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging tomjakubowski/rust/rustdoc-ice-17736 = 942bed7 into auto
942bed7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tomjakubowski/rust/rustdoc-ice-17736 = 942bed7 merged ok, testing candidate = 3edcdbb
942bed7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/1685
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/1682
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1676
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1682
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/1679
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1678
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1678
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/1682
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1676
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1675
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1678
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/1335
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1332
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1336
success: http://buildbot.rust-lang.org/builders/auto-win-64-opt/builds/169
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/168
success: http://buildbot.rust-lang.org/builders/auto-win-64-nopt-c/builds/167
942bed7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 3edcdbb