Skip to content

Commit

Permalink
Rollup merge of #41085 - nagisa:fix-output-properg, r=alexcrichton
Browse files Browse the repository at this point in the history
Properly adjust filenames when multiple emissions

Fixes #40993

Should backport just fine to beta but not sure if we want to do this since this is quite old stable regression.
  • Loading branch information
frewsxcv authored Apr 5, 2017
2 parents d0d05f5 + 201b1a9 commit 97a1f4b
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/librustc_driver/driver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1358,10 +1358,9 @@ pub fn build_output_filenames(input: &Input,
.values()
.filter(|a| a.is_none())
.count();
let ofile = if unnamed_output_types > 1 &&
sess.opts.output_types.contains_key(&OutputType::Exe) {
sess.warn("ignoring specified output filename for 'link' output because multiple \
outputs were requested");
let ofile = if unnamed_output_types > 1 {
sess.warn("due to multiple output types requested, the explicitly specified \
output file name will be adapted for each output type");
None
} else {
Some(out_file.clone())
Expand Down
7 changes: 7 additions & 0 deletions src/test/run-make/multiple-emits/Makefile
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
-include ../tools.mk

all:
$(RUSTC) foo.rs --emit=asm,llvm-ir -o $(TMPDIR)/out 2>&1
rm $(TMPDIR)/out.ll $(TMPDIR)/out.s
$(RUSTC) foo.rs --emit=asm,llvm-ir -o $(TMPDIR)/out2.ext 2>&1
rm $(TMPDIR)/out2.ll $(TMPDIR)/out2.s
11 changes: 11 additions & 0 deletions src/test/run-make/multiple-emits/foo.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

fn main() {}

0 comments on commit 97a1f4b

Please sign in to comment.