-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rustdoc: Fix file locking on windows
If the dwShareMode parameter is 0 on windows, it "prevents other processes from opening a file or device if they request delete, read, or write access", which is the opposite of what we want! This changes the 0 parameter to something which will allow multiple processes to open the file and then lock it.
- Loading branch information
1 parent
7334c11
commit 988664a
Showing
1 changed file
with
13 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
988664a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from brson
at alexcrichton@988664a
988664a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/fix-rustdoc-windows = 988664a into auto
988664a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/fix-rustdoc-windows = 988664a merged ok, testing candidate = 3e3a3cf
988664a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/4809
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/4805
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/3902
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/3910
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/4908
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/3996
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/4003
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/4910
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/3996
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/4001
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/4069
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android-t/builds/1800
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/4907
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/4007
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/4015
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/4669
988664a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 3e3a3cf