-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PR #98758 introduced code to avoid redundant assertions in derived code like this: ``` let _: ::core::clone::AssertParamIsClone<u32>; let _: ::core::clone::AssertParamIsClone<u32>; ``` But the predicate `is_simple_path` introduced as part of this failed to account for generic arguments. Therefore the deriving code erroneously considers types like `Option<bool>` and `Option<f32>` to be the same. This commit fixes `is_simple_path`. Fixes #103157.
- Loading branch information
1 parent
dfa9d5c
commit 9a23f60
Showing
4 changed files
with
49 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// check-fail | ||
|
||
#[derive(PartialEq, Eq)] | ||
pub enum Value { | ||
Boolean(Option<bool>), | ||
Float(Option<f64>), //~ ERROR the trait bound `f64: Eq` is not satisfied | ||
} | ||
|
||
fn main() { | ||
let a = Value::Float(Some(f64::NAN)); | ||
assert!(a == a); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
error[E0277]: the trait bound `f64: Eq` is not satisfied | ||
--> $DIR/issue-103157.rs:6:11 | ||
| | ||
LL | #[derive(PartialEq, Eq)] | ||
| -- in this derive macro expansion | ||
... | ||
LL | Float(Option<f64>), | ||
| ^^^^^^^^^^^ the trait `Eq` is not implemented for `f64` | ||
| | ||
= help: the following other types implement trait `Eq`: | ||
i128 | ||
i16 | ||
i32 | ||
i64 | ||
i8 | ||
isize | ||
u128 | ||
u16 | ||
and 4 others | ||
= note: required for `Option<f64>` to implement `Eq` | ||
note: required by a bound in `AssertParamIsEq` | ||
--> $SRC_DIR/core/src/cmp.rs:LL:COL | ||
| | ||
LL | pub struct AssertParamIsEq<T: Eq + ?Sized> { | ||
| ^^ required by this bound in `AssertParamIsEq` | ||
= note: this error originates in the derive macro `Eq` (in Nightly builds, run with -Z macro-backtrace for more info) | ||
|
||
error: aborting due to previous error | ||
|
||
For more information about this error, try `rustc --explain E0277`. |