-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of #134064 - jieyouxu:revert-131669, r=ChrisDenton
Revert #131669 due to ICEs Revert [lint: change help for pointers to dyn types in FFI #131669](#131669) due to ICE reports: - <#134059> (real-world) - <#134060> (fuzzing) Closes #134060. The revert criteria I used to assess whether to post this revert was: 1. It's not trivial to fix-forward. (1) The implementation itself is tricky due to `tcx.is_sized` query not being very trivial. (2) It will need more extensive test coverage for different ty kinds. 2. It is impacting real-world crates, i.e. #134059. 3. `improper_ctypes_definitions` is a warn-by-default lint. This revert is without prejudice to relanding the changes. The changes can be re-landed with those cases addressed and stronger test coverage. A rough regression test corresponding to the fuzzed example reported in #134060 is added to check that the revert worked, it is not sufficient for the lint test coverage when the lint improvements are to be relanded. Please feel free to improve the test in the reland. r? `@workingjubilee` (or compiler) cc `@niacdoial` (PR author)
- Loading branch information
Showing
17 changed files
with
208 additions
and
490 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.