-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
do not fetch variance for items when equating
Fixes #41849. Problem was that evaluating the constant expression required evaluating a trait, which would equate types, which would request variance information, which it would then discard. However, computing the variance information would require determining the type of a field, which would evaluate the constant expression. (This problem will potentially arise *later* as we move to more sophisticated constants, however, where we need to check subtyping. We can tackle that when we come to it.)
- Loading branch information
1 parent
087d737
commit a30c932
Showing
4 changed files
with
98 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// Regression test for #41849. | ||
|
||
use std::ops::Mul; | ||
|
||
const C: usize = 1; | ||
const CAPACITY: usize = 1 * C; | ||
|
||
struct A<X> { | ||
f: [X; CAPACITY], | ||
} | ||
|
||
struct B<T> { | ||
f: T, | ||
} | ||
|
||
impl<T> Mul for B<T> { | ||
type Output = Self; | ||
fn mul(self, _rhs: B<T>) -> Self::Output { | ||
self | ||
} | ||
} | ||
|
||
impl<T> Mul<usize> for B<T> { | ||
type Output = Self; | ||
fn mul(self, _rhs: usize) -> Self::Output { | ||
self | ||
} | ||
} | ||
|
||
fn main() { | ||
let a = A { f: [1] }; | ||
let _ = B { f: a }; | ||
} |