Skip to content

Commit

Permalink
Revert "opt-dist: dont overrwite config.toml when verifying"
Browse files Browse the repository at this point in the history
This reverts commit c81a40b.
  • Loading branch information
Mark-Simulacrum committed Jul 30, 2024
1 parent 649d99b commit abb1eba
Showing 1 changed file with 17 additions and 14 deletions.
31 changes: 17 additions & 14 deletions src/tools/opt-dist/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,26 @@ pub fn run_tests(env: &Environment) -> anyhow::Result<()> {
.join(format!("llvm-config{}", executable_extension()));
assert!(llvm_config.is_file());

let rustc = format!("build.rustc={}", rustc_path.to_string().replace('\\', "/"));
let cargo = format!("build.cargo={}", cargo_path.to_string().replace('\\', "/"));
let llvm_config =
format!("target.{host_triple}.llvm-config={}", llvm_config.to_string().replace('\\', "/"));
let config_content = format!(
r#"profile = "user"
change-id = 115898
log::info!("Set the following configurations for running tests:");
log::info!("\t{rustc}");
log::info!("\t{cargo}");
log::info!("\t{llvm_config}");
[build]
rustc = "{rustc}"
cargo = "{cargo}"
[target.{host_triple}]
llvm-config = "{llvm_config}"
"#,
rustc = rustc_path.to_string().replace('\\', "/"),
cargo = cargo_path.to_string().replace('\\', "/"),
llvm_config = llvm_config.to_string().replace('\\', "/")
);
log::info!("Using following `config.toml` for running tests:\n{config_content}");

// Simulate a stage 0 compiler with the extracted optimized dist artifacts.
std::fs::write("config.toml", config_content)?;

let x_py = env.checkout_path().join("x.py");
let mut args = vec![
env.python_binary(),
Expand All @@ -88,12 +97,6 @@ pub fn run_tests(env: &Environment) -> anyhow::Result<()> {
"tests/run-pass-valgrind",
"tests/ui",
"tests/crashes",
"--set",
&rustc,
"--set",
&cargo,
"--set",
&llvm_config,
];
for test_path in env.skipped_tests() {
args.extend(["--skip", test_path]);
Expand Down

0 comments on commit abb1eba

Please sign in to comment.