-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix #3225: Incorporate feedback from Graydon.
This is a small follow-up fix to the previous commit: I needed to quote the right-hand side of the definition for the variable MATCHES, to handle the case where there are more than one previously installed libraries in the target directory.
- Loading branch information
Showing
1 changed file
with
11 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from graydon
at pnkfelix@ace4944
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pnkfelix/rust/fsk-guard-against-stale-libraries-issue3225-safeguarded = ace4944 into auto
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnkfelix/rust/fsk-guard-against-stale-libraries-issue3225-safeguarded = ace4944 merged ok, testing candidate = 220a5624
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some tests failed:
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/328
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt/builds/329
http://buildbot.rust-lang.org/builders/auto-mac-64-opt-vg/builds/324
http://buildbot.rust-lang.org/builders/auto-mac-all-opt/builds/326
http://buildbot.rust-lang.org/builders/auto-linux-32-nopt/builds/350
http://buildbot.rust-lang.org/builders/auto-linux-64-nopt/builds/350
http://buildbot.rust-lang.org/builders/auto-linux-all-opt/builds/347
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from graydon
at pnkfelix@ace4944
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging pnkfelix/rust/fsk-guard-against-stale-libraries-issue3225-safeguarded = ace4944 into auto
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnkfelix/rust/fsk-guard-against-stale-libraries-issue3225-safeguarded = ace4944 merged ok, testing candidate = 8a7b636
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/338
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/340
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt/builds/343
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt-vg/builds/336
success: http://buildbot.rust-lang.org/builders/auto-mac-all-opt/builds/340
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/359
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt/builds/362
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/359
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt/builds/362
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt-vg/builds/365
success: http://buildbot.rust-lang.org/builders/auto-linux-all-opt/builds/358
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/342
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt/builds/358
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/137
ace4944
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 8a7b636