Skip to content

Commit

Permalink
Auto merge of #88717 - tabokie:vecdeque-fast-append, r=m-ou-se
Browse files Browse the repository at this point in the history
Optimize VecDeque::append

Optimize `VecDeque::append` to do unsafe copy rather than iterating through each element.

On my `Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz`, the benchmark shows 37% improvements:
```
Master:
custom-bench vec_deque_append 583164 ns/iter
custom-bench vec_deque_append 550040 ns/iter

Patched:
custom-bench vec_deque_append 349204 ns/iter
custom-bench vec_deque_append 368164 ns/iter
```

Additional notes on the context: this is the third attempt to implement a non-trivial version of `VecDeque::append`, the last two are reverted due to unsoundness or regression, see:
- #52553, reverted in #53571
- #53564, reverted in #54851

Both cases are covered by existing tests.

Signed-off-by: tabokie <xy.tao@outlook.com>
  • Loading branch information
bors committed Oct 15, 2021
2 parents 1dafe6d + cd773c3 commit af9b508
Showing 1 changed file with 30 additions and 2 deletions.
32 changes: 30 additions & 2 deletions library/alloc/src/collections/vec_deque/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,25 @@ impl<T, A: Allocator> VecDeque<T, A> {
}
}

/// Copies all values from `src` to `dst`, wrapping around if needed.
/// Assumes capacity is sufficient.
#[inline]
unsafe fn copy_slice(&mut self, dst: usize, src: &[T]) {
debug_assert!(src.len() <= self.cap());
let head_room = self.cap() - dst;
if src.len() <= head_room {
unsafe {
ptr::copy_nonoverlapping(src.as_ptr(), self.ptr().add(dst), src.len());
}
} else {
let (left, right) = src.split_at(head_room);
unsafe {
ptr::copy_nonoverlapping(left.as_ptr(), self.ptr().add(dst), left.len());
ptr::copy_nonoverlapping(right.as_ptr(), self.ptr(), right.len());
}
}
}

/// Frobs the head and tail sections around to handle the fact that we
/// just reallocated. Unsafe because it trusts old_capacity.
#[inline]
Expand Down Expand Up @@ -2081,8 +2100,17 @@ impl<T, A: Allocator> VecDeque<T, A> {
#[inline]
#[stable(feature = "append", since = "1.4.0")]
pub fn append(&mut self, other: &mut Self) {
// naive impl
self.extend(other.drain(..));
self.reserve(other.len());
unsafe {
let (left, right) = other.as_slices();
self.copy_slice(self.head, left);
self.copy_slice(self.wrap_add(self.head, left.len()), right);
}
// SAFETY: Update pointers after copying to avoid leaving doppelganger
// in case of panics.
self.head = self.wrap_add(self.head, other.len());
// Silently drop values in `other`.
other.tail = other.head;
}

/// Retains only the elements specified by the predicate.
Expand Down

0 comments on commit af9b508

Please sign in to comment.