Skip to content

Commit

Permalink
Remove a debug! statement before I/O is ready
Browse files Browse the repository at this point in the history
The logging macros all use libuv-based I/O, and there was one stray debug
statement in task::spawn which was executing before the I/O context was ready.
Remove it and add a test to make sure that we can continue to debug this sort of
code.

Closes #10405
  • Loading branch information
alexcrichton committed Nov 10, 2013
1 parent 3851f90 commit b71d629
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/libstd/task/spawn.rs
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,6 @@ pub fn spawn_raw(mut opts: TaskOpts, f: ~fn()) {
};
new_sched.bootstrap(bootstrap_task);

debug!("enqueing join_task");
// Now tell the original scheduler to join with this thread
// by scheduling a thread-joining task on the original scheduler
orig_sched_handle.send(TaskFromFriend(join_task));
Expand Down
22 changes: 22 additions & 0 deletions src/test/run-pass/spawning-with-debug.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// exec-env:RUST_LOG=debug
// xfail-fast

// regression test for issue #10405, make sure we don't call debug! too soon.

use std::task;

fn main() {
let mut t = task::task();
t.sched_mode(task::SingleThreaded);
t.spawn(|| ());
}

5 comments on commit b71d629

@bors
Copy link
Contributor

@bors bors commented on b71d629 Nov 11, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from huonw
at alexcrichton@b71d629

@bors
Copy link
Contributor

@bors bors commented on b71d629 Nov 11, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging alexcrichton/rust/issue-10405 = b71d629 into auto

@bors
Copy link
Contributor

@bors bors commented on b71d629 Nov 11, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alexcrichton/rust/issue-10405 = b71d629 merged ok, testing candidate = 63cfc99

@bors
Copy link
Contributor

@bors bors commented on b71d629 Nov 11, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors
Copy link
Contributor

@bors bors commented on b71d629 Nov 11, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 63cfc99

Please sign in to comment.