-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove a debug! statement before I/O is ready
The logging macros all use libuv-based I/O, and there was one stray debug statement in task::spawn which was executing before the I/O context was ready. Remove it and add a test to make sure that we can continue to debug this sort of code. Closes #10405
- Loading branch information
1 parent
3851f90
commit b71d629
Showing
2 changed files
with
22 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// exec-env:RUST_LOG=debug | ||
// xfail-fast | ||
|
||
// regression test for issue #10405, make sure we don't call debug! too soon. | ||
|
||
use std::task; | ||
|
||
fn main() { | ||
let mut t = task::task(); | ||
t.sched_mode(task::SingleThreaded); | ||
t.spawn(|| ()); | ||
} |
b71d629
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saw approval from huonw
at alexcrichton@b71d629
b71d629
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging alexcrichton/rust/issue-10405 = b71d629 into auto
b71d629
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alexcrichton/rust/issue-10405 = b71d629 merged ok, testing candidate = 63cfc99
b71d629
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass:
success: http://buildbot.rust-lang.org/builders/auto-mac-32-opt/builds/2404
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-c/builds/250
success: http://buildbot.rust-lang.org/builders/auto-mac-32-nopt-t/builds/250
success: http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/2408
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-c/builds/1514
success: http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/1513
success: http://buildbot.rust-lang.org/builders/auto-linux-32-opt/builds/2422
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-c/builds/1514
success: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/1514
success: http://buildbot.rust-lang.org/builders/auto-linux-64-opt/builds/2423
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-c/builds/1514
success: http://buildbot.rust-lang.org/builders/auto-linux-64-nopt-t/builds/1514
success: http://buildbot.rust-lang.org/builders/auto-linux-64-x-android/builds/1590
success: http://buildbot.rust-lang.org/builders/auto-win-32-opt/builds/2408
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-c/builds/1512
success: http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/1514
success: http://buildbot.rust-lang.org/builders/auto-bsd-64-opt/builds/2186
b71d629
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fast-forwarding master to auto = 63cfc99