Skip to content

Commit

Permalink
Rollup merge of #132828 - est31:let_chains_parsing_tests, r=compiler-…
Browse files Browse the repository at this point in the history
…errors

Additional tests to ensure let is rejected during parsing

In the original stabilization PR, @ `compiler-errors` has [pointed out](#94927 (comment)) that #97295 wasn't enough to address the concerns about having `let` in expressions being rejected at parsing time, instead of later.

Thankfully, since then the situation has been greatly improved by #115677. This PR adds some additional tests to `disallowed-positions.rs`, and adds two additional revisions to the "normal" case which is now given the `feature` name:

* `no_feature`: Added to incorporate `disallowed-positions-without-feature-gate.rs` into the file, reducing duplication.
* `nothing`: like feature, but all functions are cfg'd out. Ensures that the errors are really emitted during parsing.

cc tracking issue #53667
  • Loading branch information
workingjubilee authored Nov 10, 2024
2 parents 0ba1770 + 935bf69 commit c19d56c
Show file tree
Hide file tree
Showing 6 changed files with 2,842 additions and 652 deletions.

This file was deleted.

Loading

0 comments on commit c19d56c

Please sign in to comment.