Skip to content

Commit

Permalink
Fix FIXME #5475 in std::ascii
Browse files Browse the repository at this point in the history
Issue #5475 was closed some time ago, but ascii.rs still contained
a FIXME for it.
  • Loading branch information
Sawyer47 committed May 25, 2014
1 parent bbb70cd commit d12e12e
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions src/libstd/ascii.rs
Original file line number Diff line number Diff line change
Expand Up @@ -591,13 +591,10 @@ mod tests {
fn test_ascii_vec() {
let test = &[40u8, 32u8, 59u8];
assert_eq!(test.to_ascii(), v2ascii!([40, 32, 59]));
assert_eq!("( ;".to_ascii(), v2ascii!([40, 32, 59]));
// FIXME: #5475 borrowchk error, owned vectors do not live long enough
// if chained-from directly
assert_eq!("( ;".to_ascii(), v2ascii!([40, 32, 59]));
let v = box [40u8, 32u8, 59u8];
assert_eq!(v.to_ascii(), v2ascii!([40, 32, 59]));
let v = "( ;".to_strbuf();
assert_eq!(v.as_slice().to_ascii(), v2ascii!([40, 32, 59]));
assert_eq!("( ;".to_strbuf().as_slice().to_ascii(), v2ascii!([40, 32, 59]));

assert_eq!("abCDef&?#".to_ascii().to_lower().into_str(), "abcdef&?#".to_strbuf());
assert_eq!("abCDef&?#".to_ascii().to_upper().into_str(), "ABCDEF&?#".to_strbuf());
Expand Down

9 comments on commit d12e12e

@bors
Copy link
Contributor

@bors bors commented on d12e12e May 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from huonw
at Sawyer47@d12e12e

@bors
Copy link
Contributor

@bors bors commented on d12e12e May 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging Sawyer47/rust/ascii-fixme = d12e12e into auto

@bors
Copy link
Contributor

@bors bors commented on d12e12e May 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sawyer47/rust/ascii-fixme = d12e12e merged ok, testing candidate = aeb7d625

@bors
Copy link
Contributor

@bors bors commented on d12e12e May 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw approval from huonw
at Sawyer47@d12e12e

@bors
Copy link
Contributor

@bors bors commented on d12e12e May 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging Sawyer47/rust/ascii-fixme = d12e12e into auto

@bors
Copy link
Contributor

@bors bors commented on d12e12e May 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sawyer47/rust/ascii-fixme = d12e12e merged ok, testing candidate = 6b1426b

@bors
Copy link
Contributor

@bors bors commented on d12e12e May 25, 2014

@bors
Copy link
Contributor

@bors bors commented on d12e12e May 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast-forwarding master to auto = 6b1426b

Please sign in to comment.