-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rollup merge of #44361 - oli-obk:lit_sugg, r=nikomatsakis
Suggest changing literals instead of calling methods (fixes #44307)
- Loading branch information
Showing
3 changed files
with
71 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
|
||
fn main() { | ||
let x: &[u8] = "foo"; | ||
let y: &[u8; 4] = "baaa"; | ||
let z: &str = b"foo"; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
error[E0308]: mismatched types | ||
--> $DIR/str-lit-type-mismatch.rs:13:20 | ||
| | ||
13 | let x: &[u8] = "foo"; | ||
| ^^^^^ expected slice, found str | ||
| | ||
= note: expected type `&[u8]` | ||
found type `&'static str` | ||
= help: try `b"foo"` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/str-lit-type-mismatch.rs:14:23 | ||
| | ||
14 | let y: &[u8; 4] = "baaa"; | ||
| ^^^^^^ expected array of 4 elements, found str | ||
| | ||
= note: expected type `&[u8; 4]` | ||
found type `&'static str` | ||
= help: try `b"baaa"` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/str-lit-type-mismatch.rs:15:19 | ||
| | ||
15 | let z: &str = b"foo"; | ||
| ^^^^^^ expected str, found array of 3 elements | ||
| | ||
= note: expected type `&str` | ||
found type `&'static [u8; 3]` | ||
= help: try `"foo"` | ||
|
||
error: aborting due to 3 previous errors | ||
|