Skip to content

Commit

Permalink
Rollup merge of #127850 - jieyouxu:bootstrap-llvm-config, r=onur-ozkan
Browse files Browse the repository at this point in the history
bootstrap: open `llvm-config` as r+w

This previously failed on Windows and prevented building on Windows for compiler stuff because the `llvm-config` file was open as read-only.

Tested locally on a Windows machine.

Fixes #127849.
  • Loading branch information
tgross35 authored Jul 17, 2024
2 parents 5d7466e + 3bee507 commit f99f61b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/bootstrap/src/core/download.rs
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ download-rustc = false
let file_times = fs::FileTimes::new().set_accessed(now).set_modified(now);

let llvm_config = llvm_root.join("bin").join(exe("llvm-config", self.build));
let llvm_config_file = t!(File::open(llvm_config));
let llvm_config_file = t!(File::options().write(true).open(llvm_config));

t!(llvm_config_file.set_times(file_times));

Expand Down

0 comments on commit f99f61b

Please sign in to comment.