Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for slice::split_at in const context #101158

Closed
3 tasks done
tspiteri opened this issue Aug 29, 2022 · 5 comments
Closed
3 tasks done

Tracking Issue for slice::split_at in const context #101158

tspiteri opened this issue Aug 29, 2022 · 5 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@tspiteri
Copy link
Contributor

tspiteri commented Aug 29, 2022

Feature gate: #![feature(const_slice_split_at_not_mut)]

This is a tracking issue for usage of slice::split_at in const context.

Public API

impl<T> [T] {
    pub const fn split_at(&self, mid: usize) -> (&[T], &[T]);
}

Steps / History

Unresolved Questions

  • None yet.
@tspiteri tspiteri added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 29, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this issue Aug 30, 2022
…t, r=Mark-Simulacrum

add tracking issue number to const_slice_split_at_not_mut

Add issue number rust-lang#101158 to `const_slice_split_at_not_mut` feature.
JohnTitor added a commit to JohnTitor/rust that referenced this issue Aug 30, 2022
…t, r=Mark-Simulacrum

add tracking issue number to const_slice_split_at_not_mut

Add issue number rust-lang#101158 to `const_slice_split_at_not_mut` feature.
@m-ou-se
Copy link
Member

m-ou-se commented May 1, 2023

@rfcbot merge

cc @rust-lang/wg-const-eval

@rfcbot
Copy link

rfcbot commented May 1, 2023

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels May 1, 2023
@rfcbot
Copy link

rfcbot commented May 4, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 14, 2023
@rfcbot
Copy link

rfcbot commented May 14, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

bors added a commit to rust-lang-ci/rust that referenced this issue May 15, 2023
…t, r=dtolnay

Stabilize const slice::split_at

This stabilizes the use of the following method in const context:

```rust
impl<T> [T] {
    pub const fn split_at(&self, mid: usize) -> (&[T], &[T]);
}
```

cc tracking issue rust-lang#101158
@scottmcm
Copy link
Member

Stabilization PR landed; closing.

@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants