fs::stat() returns truncated created, modified, and accessed times

[williamw520]

In 0.9-pre codeline, fs::stat() returns truncated times.

The problem seems to be in uvio::fs_mkstat(). fs::stat() calls io::fs_lstat() which calls uvio::fs_mkstat(). Its to_msec() converts an C time from uv_timespec_t into Rust time.

struct uv_timespec_t {
    tv_sec: libc::c_long,
    tv_nsec: libc::c_long
}

tv_sec and tv_nsec are in c_long, which can be 32-bit. to_msec() multiplies tv_sec with 1000, which will truncate the high bits of a large 32-bit time value. tv_sec needs to be casted to u64 before multiplied with 1000 to avoid the truncation problem.

[huonw]

cc @alexcrichton

[alexcrichton]

Hm, it appears that my laziness of not wanting to write as u64 twice has come back to haunt me.

Thanks for reporting this! I've fixed this in a local branch which I intend to land soon.