Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc "source" links are not clickable #104313

Closed
RalfJung opened this issue Nov 12, 2022 · 3 comments · Fixed by #104319 or #104177
Closed

rustdoc "source" links are not clickable #104313

RalfJung opened this issue Nov 12, 2022 · 3 comments · Fixed by #104319 or #104177

Comments

@RalfJung
Copy link
Member

RalfJung commented Nov 12, 2022 •
edited
Loading

To reproduce, navigate to https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/ty/struct.Ty.html and click the the "source" link for any of the methods. Nothing at all happens when I do that. I tried Firefox and Chromium.

This seems to be a fairly recent regression.

@rust-lang/rustdoc
@GuillaumeGomez
Copy link
Member

It's because it's under the h4 for some reason. Let's see what changed in the last few days.

@GuillaumeGomez
Copy link
Member

I think it's because of 303653e. I'll try to send a fix today.

@GuillaumeGomez
Copy link
Member

It's because .code-header added a position: relative to have a correct positioning of the tooltip on mobile devices.

This was referenced Nov 12, 2022
Merged
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 12, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104319 - GuillaumeGomez:fix-non-clickable-s…
669155c 
…ource-link, r=notriddle

Fix non clickable source link

Fixes rust-lang#104313.

It was also fixed in rust-lang#104177. If rust-lang#104177 is merged first, I'll simply remove the first commit to keep the test.

r? `@notriddle`
@bors bors closed this as completed in d532d67 Nov 12, 2022
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 12, 2022
@Manishearth
Rollup merge of rust-lang#104177 - notriddle:notriddle/js-notable-tra…
36d2291 
…it-v2, r=GuillaumeGomez

rustdoc: use consistent "popover" styling for notable traits

Follow-up to rust-lang#104129
Fixes rust-lang#104313.

Preview: https://notriddle.com/notriddle-rustdoc-demos/js-notable-trait-v2/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200710372-d2d992ce-0bdc-4437-9a2e-379a29df09cf.png)

![image](https://user-images.githubusercontent.com/1593513/200711266-e372b176-daa9-45f3-a022-738ef0a77d3c.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200710601-09b3b717-116f-43c6-b14f-34a8b02b33c0.png)

![image](https://user-images.githubusercontent.com/1593513/200711288-3978cdc1-a6c2-47f6-9216-e22e3c1f5bdf.png)
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Nov 13, 2022
Rollup merge of rust-lang#104177 - notriddle:notriddle/js-notable-tra…
528b4af 
…it-v2, r=GuillaumeGomez

rustdoc: use consistent "popover" styling for notable traits

Follow-up to rust-lang#104129
Fixes rust-lang#104313.

Preview: https://notriddle.com/notriddle-rustdoc-demos/js-notable-trait-v2/std/iter/trait.Iterator.html#method.step_by

## Before

![image](https://user-images.githubusercontent.com/1593513/200710372-d2d992ce-0bdc-4437-9a2e-379a29df09cf.png)

![image](https://user-images.githubusercontent.com/1593513/200711266-e372b176-daa9-45f3-a022-738ef0a77d3c.png)

## After

![image](https://user-images.githubusercontent.com/1593513/200710601-09b3b717-116f-43c6-b14f-34a8b02b33c0.png)

![image](https://user-images.githubusercontent.com/1593513/200711288-3978cdc1-a6c2-47f6-9216-e22e3c1f5bdf.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@RalfJung @GuillaumeGomez