-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad generic inference on very recent nightly #105037
Labels
A-const-generics
Area: const generics (parameters and arguments)
C-bug
Category: This is a bug.
F-generic_const_exprs
`#![feature(generic_const_exprs)]`
Comments
BGluth
added a commit
to 0xPolygonZero/plonky2
that referenced
this issue
Nov 29, 2022
- Needed until rust-lang/rust#105037 is fixed.
compiler-errors
added
the
E-needs-bisection
Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
label
Nov 29, 2022
@compiler-errors Please remove the "E-needs-bisection" (also, how can I do that?) searched nightlies: from nightly-2022-11-25 to nightly-2022-11-29 bisected with cargo-bisect-rustc v0.6.4Host triple: x86_64-unknown-linux-gnu |
compiler-errors
removed
the
E-needs-bisection
Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
label
Nov 29, 2022
thanks @mucinoab |
BoxyUwU
added
A-const-generics
Area: const generics (parameters and arguments)
F-generic_const_exprs
`#![feature(generic_const_exprs)]`
labels
Nov 29, 2022
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this issue
Jan 9, 2023
…yUwU Change a commit_if_ok call to probe Removes an over-eager `commit_if_ok` which makes inference worse. I'm not entirely sure whether it's ok to remove the check that types are the same, because casting seems to cause equality checks with incorrect types? Fixes rust-lang#105037 r? `@BoxyUwU`
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this issue
Jan 9, 2023
…yUwU Change a commit_if_ok call to probe Removes an over-eager `commit_if_ok` which makes inference worse. I'm not entirely sure whether it's ok to remove the check that types are the same, because casting seems to cause equality checks with incorrect types? Fixes rust-lang#105037 r? ``@BoxyUwU``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-const-generics
Area: const generics (parameters and arguments)
C-bug
Category: This is a bug.
F-generic_const_exprs
`#![feature(generic_const_exprs)]`
We noticed a build error in Plonky2 on the nightly build 2022-11-27. The same code was building last week, on a slightly older nightly.
Here's a minimal reproducible example (Playground):
Nightly 2022-11-27 gives this error:
It seems to be sensitive to the order of the where clauses,
[(); Table1::<D>::COLUMNS]:
and[(); Table2::<D>::COLUMNS]:
. I.e. for aprocess_table
call, it seems to infer thatT
is whicheverTable
appeared last in thewhere
list.The text was updated successfully, but these errors were encountered: