Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsFd and AsRawFd are implemented for Arc<T>, but not Rc<T> #105931

Closed
ids1024 opened this issue Dec 20, 2022 · 0 comments · Fixed by #107317
Closed

AsFd and AsRawFd are implemented for Arc<T>, but not Rc<T> #105931

ids1024 opened this issue Dec 20, 2022 · 0 comments · Fixed by #107317

Comments

@ids1024
Copy link
Contributor

ids1024 commented Dec 20, 2022

I was looking through the list of things that implement AsFd, and noticed there's an implementation for Arc<T> where T: AsFd, but not for Rc. I don't think there's any subtle any subtle reason this couldn't/shouldn't be implemented for Rc too?
@ids1024 ids1024 mentioned this issue Jan 26, 2023
Merged
compiler-errors added a commit to compiler-errors/rust that referenced this issue Feb 9, 2023
@compiler-errors
Rollup merge of rust-lang#107317 - ids1024:asfd-rc, r=dtolnay
a0df26c 
Implement `AsFd` and `AsRawFd` for `Rc`

Fixes rust-lang#105931.
compiler-errors added a commit to compiler-errors/rust that referenced this issue Feb 9, 2023
@compiler-errors
Rollup merge of rust-lang#107317 - ids1024:asfd-rc, r=dtolnay
4212d25 
Implement `AsFd` and `AsRawFd` for `Rc`

Fixes rust-lang#105931.
compiler-errors added a commit to compiler-errors/rust that referenced this issue Feb 9, 2023
@compiler-errors
Rollup merge of rust-lang#107317 - ids1024:asfd-rc, r=dtolnay
a478b83 
Implement `AsFd` and `AsRawFd` for `Rc`

Fixes rust-lang#105931.
@bors bors closed this as completed in c13669e Feb 9, 2023
RalfJung pushed a commit to RalfJung/miri that referenced this issue Feb 9, 2023
@compiler-errors
Rollup merge of #107317 - ids1024:asfd-rc, r=dtolnay
085bc3a 
Implement `AsFd` and `AsRawFd` for `Rc`

Fixes rust-lang/rust#105931.
thomcc pushed a commit to tcdi/postgrestd that referenced this issue May 31, 2023
@ids1024
Implement AsFd and AsRawFd for Rc
1774374 
Fixes rust-lang/rust#105931.
thomcc pushed a commit to tcdi/postgrestd that referenced this issue May 31, 2023
@compiler-errors
Rollup merge of #107317 - ids1024:asfd-rc, r=dtolnay
341ae7f 
Implement `AsFd` and `AsRawFd` for `Rc`

Fixes rust-lang/rust#105931.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement AsFd and AsRawFd for Rc ids1024/rust
1 participant
@ids1024