Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: failed to resolve proc macro definition #106337

Closed
Mark-Simulacrum opened this issue Jan 1, 2023 · 5 comments
Closed

regression: failed to resolve proc macro definition #106337

Mark-Simulacrum opened this issue Jan 1, 2023 · 5 comments
Assignees
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

The prelude module from which the macro should be imported is defined like this:

    pub use serde::Serialize;
    pub use job::{Args, Job, JobName, JobResult, PerformJob};
    pub use error::RobinResult;
    pub use connection::{establish, LookupJob, WorkerConnection};
    pub use worker::boot;
    pub use config::Config;
    pub use robin_derives::*;
    pub use macros::*;

I suspect that the glob import here isn't properly being treated as introducing Job, but without a bisection/further debugging hard to say.

cc @petrochenkov

@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Jan 1, 2023
@Mark-Simulacrum Mark-Simulacrum added this to the 1.67.0 milestone Jan 1, 2023
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jan 1, 2023
@Mark-Simulacrum
Copy link
Member Author

@apiraino
Copy link
Contributor

apiraino commented Jan 4, 2023

cargo +beta-2022-12-29 test to reproduce for crate box_shorthand. The bisection of both points at commit ab5a2bc, which is a rollup. Probably @Mark-Simulacrum you meant #103760 from that rollup, correct?

I cannot reproduce the error on the "robin" crate, I only get the warnings. Are these warnings fine?
I'm running:

$ cargo +beta-2022-12-29 --version
cargo 1.67.0-beta.5 (f6e737b1e 2022-12-02)

$ CARGO_INCREMENTAL=0 RUSTFLAGS=--cap-lints=warn \
    cargo +beta-2022-12-29 test --no-run --frozen

@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-critical

@rustbot rustbot added P-critical Critical priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jan 10, 2023
@pnkfelix pnkfelix self-assigned this Jan 12, 2023
@petrochenkov petrochenkov self-assigned this Jan 12, 2023
@petrochenkov petrochenkov removed their assignment Jan 20, 2023
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 22, 2023
This reverts commit 7d82cad.

I am doing this to buy us some time with respect to issue rust-lang#106337 w.r.t. the
1.67 release.
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 22, 2023
…06337, r=Mark-Simulacrum

Revert "Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error"

This reverts commit 7d82cad aka PR rust-lang#84022

I am doing this to buy us some time with respect to issue rust-lang#106337 w.r.t. the 1.67 release.
@pnkfelix
Copy link
Member

@rustbot label: +P-high -P-critical

(downgrading priority as PR #84022 has been reverted via #107133 (and in beta via #107164 )

@rustbot rustbot added P-high High priority and removed P-critical Critical priority labels Jan 26, 2023
@apiraino
Copy link
Contributor

apiraino commented Feb 15, 2023

can this be closed since the backport of #107133?

EDIT: I think so: beta backported in #107164

xobs pushed a commit to betrusted-io/rust that referenced this issue Mar 24, 2023
This reverts commit 7d82cad.

I am doing this to buy us some time with respect to issue rust-lang#106337 w.r.t. the
1.67 release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants