-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression 1.67.0: Static archives have different unix permissions than before #107495
Comments
#107360 reverted back to the LLVM archive writer to fix another regression. Still I think this issuw should be kept open as a reminder to fix the new archive writer before it becomes the default again. |
cc #107407, which also needs to be fixed before relanding the archive writer change. BTW @bjorn3 is there a tracking issue for that somewhere? I see the original PR linked to https://github.com/bjorn3/rustc_codegen_cranelift/issues/1155, but it hasn't been reopened. |
I have kept all issues that need to be fixed before it can land again in my github notifications. There is currently no tracking issue, but feel free to open one. It did probably be a good idea to ensure no issue is forgotten about. |
static libraries with ar_archive_writer Fixes rust-lang#107495
static libraries with ar_archive_writer Fixes rust-lang#107495
…thercote Use same file permissions for ar_archive_writer as the LLVM archive writer This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions. Fixes rust-lang#107495
…thercote Use same file permissions for ar_archive_writer as the LLVM archive writer This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions. Fixes rust-lang#107495
…thercote Use same file permissions for ar_archive_writer as the LLVM archive writer This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions. Fixes rust-lang#107495
static libraries with ar_archive_writer Fixes rust-lang#107495
static libraries with ar_archive_writer Fixes rust-lang#107495
…thercote Use same file permissions for ar_archive_writer as the LLVM archive writer This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions. Fixes rust-lang#107495
Rollup merge of rust-lang#122723 - bjorn3:archive_writer_fixes, r=nnethercote Use same file permissions for ar_archive_writer as the LLVM archive writer This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions. Fixes rust-lang#107495
Use same file permissions for ar_archive_writer as the LLVM archive writer This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang/rust#107407) to fix all known regressions. Fixes rust-lang/rust#107495
static libraries with ar_archive_writer Fixes rust-lang#107495
…=jieyouxu Support reading thin archives in ArArchiveBuilder And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed. Fixes rust-lang#107407 Fixes rust-lang#107162 rust-lang#107495 has been fixed in a previous PR already.
…=jieyouxu Support reading thin archives in ArArchiveBuilder And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed. Fixes rust-lang#107407 Fixes rust-lang#107162 rust-lang#107495 has been fixed in a previous PR already.
…=jieyouxu Support reading thin archives in ArArchiveBuilder And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed. Fixes rust-lang#107407 Fixes rust-lang#107162 rust-lang#107495 has been fixed in a previous PR already.
…try> Support reading thin archives in ArArchiveBuilder And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed. Fixes rust-lang#107407 Fixes rust-lang#107162 rust-lang#107495 has been fixed in a previous PR already. try-job: dist-aarch64-msvc
…ieyouxu Support reading thin archives in ArArchiveBuilder And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed. Fixes rust-lang#107407 Fixes rust-lang#107162 rust-lang#107495 has been fixed in a previous PR already.
…ieyouxu Support reading thin archives in ArArchiveBuilder And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed. Fixes rust-lang#107407 Fixes rust-lang#107162 rust-lang#107495 has been fixed in a previous PR already.
Support reading thin archives in ArArchiveBuilder And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed. Fixes rust-lang/rust#107407 Fixes rust-lang/rust#107162 rust-lang/rust#107495 has been fixed in a previous PR already.
Support reading thin archives in ArArchiveBuilder And switch to using ArArchiveBuilder with the LLVM backend too now that all regressions are fixed. Fixes rust-lang/rust#107407 Fixes rust-lang/rust#107162 rust-lang/rust#107495 has been fixed in a previous PR already.
Given this code:
I get this output from rustc:
The most recent archive no longer has the "read" permission bit set for group/world owners. This ended up breaking Wasmtime's build because our files are built in a container with a different user and aren't then readable outside of the container. There's no particular reason we do this and we can work around this, but I also suspected that the change in permissions here probably wasn't intentional.
I think this is due to #97485 (cc @bjorn3), specifically this line. I haven't dug too deeply but my guess is that temp files specifically turn off other permission bits
The text was updated successfully, but these errors were encountered: