OwningRef is included in the compiler despite known soundness problems.
#109974
Assignees
Labels
C-discussion
Category: Discussion or questions that doesn't represent real issues.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
|
Great timing! #109971 |
Noratrieb
changed the title
OwningRef is included in the compiler despite known soundness problems.OwningRef is included in the compiler despite known soundness problems.
Noratrieb
added
the
T-compiler
Merged
Noratrieb
added
the
C-discussion
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this issue
Apr 7, 2023
…strieb Yeet `owning_ref` Based on the discussions from rust-lang#109948 This replaces `owning_ref` with a far simpler & safer abstraction. Fixes rust-lang#109974
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this issue
Apr 7, 2023
…strieb Yeet `owning_ref` Based on the discussions from rust-lang#109948 This replaces `owning_ref` with a far simpler & safer abstraction. Fixes rust-lang#109974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
OwningRefmodule in rustc_data_structures, which seems to be a copy of this crate (perhaps with small additions?), has known soundness issues.I wrote an article about the soundness problems here.
It's used in rustc in
MetadataRefand related things. (I don't know if it's used anywhere else).I don't know of any actual unsafe use of this crate in rustc, but I haven't actually tried to look for any.
IMO, in order to keep the code safe, either
owning_refshould be replaced with something else, or otherwise, it should be updated to contain the known fixes to these soundness problems (here).The text was updated successfully, but these errors were encountered: