-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to link use of hyper_util with -Zsanitizer=address on msvc #124390
Comments
I couldn't reproduce it with the latest nightly build. Is this still an issue? |
Yeah, the reproducer I posted earlier seems to be fixed. However, the bug does still exist. New reproducer: // Cargo.toml
// [package]
// name = "conflicting_weak_bug"
// version = "0.1.0"
// edition = "2021"
// [dependencies]
// tokio = { version = "1.39.2", features = ["rt-multi-thread"] }
fn main() {
let _ = tokio::runtime::Builder::new_multi_thread()
.build()
.unwrap();
} Tested with This was actually my original reproducer, but I minimized it to hyper to have it be simpler. |
I am encountering the same issue in an app with a multi-threaded tokio runtime (although my version of the error message shows a symbol conflict between a different library and my main executable) |
PassWrapper: disable UseOdrIndicator for Asan Win32 As described in https://reviews.llvm.org/D137227 UseOdrIndicator should be disabled on Windows since link.exe does not support duplicate weak definitions. Fixes rust-lang#124390. Credits also belong to `@1c3t3a` who worked with me on this. We are currently testing this on a Windows machine.
Rollup merge of rust-lang#132773 - jakos-sec:fix-asan-win32, r=jieyouxu PassWrapper: disable UseOdrIndicator for Asan Win32 As described in https://reviews.llvm.org/D137227 UseOdrIndicator should be disabled on Windows since link.exe does not support duplicate weak definitions. Fixes rust-lang#124390. Credits also belong to `@1c3t3a` who worked with me on this. We are currently testing this on a Windows machine.
I tried this code:
With
RUSTFLAGS=-Zsanitizer=address
, I runcargo +nightly build --target=x86_64-pc-windows-msvc
I expected to see this happen: build succeeds
Instead, this happened: Build fails:
Seems somwhat similar to #85461, however setting
-Ccodegen-units=1
does not workaround the issue.Meta
rustc --version --verbose
:MSVC version 14.39.33519
The text was updated successfully, but these errors were encountered: