Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for is_none_or #126383

Closed
2 of 4 tasks
RalfJung opened this issue Jun 13, 2024 · 4 comments · Fixed by #129086
Closed
2 of 4 tasks

Tracking Issue for is_none_or #126383

RalfJung opened this issue Jun 13, 2024 · 4 comments · Fixed by #129086
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Jun 13, 2024

Feature gate: #![feature(is_none_or)]

This is a tracking issue for Option::is_none_or.

Public API

impl<T> Option<T> {
    pub fn is_none_or(self, f: impl FnOnce(T) -> bool) -> bool {
}

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html

@RalfJung RalfJung added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Jun 13, 2024
fmease added a commit to fmease/rust that referenced this issue Jun 13, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 13, 2024
Rollup merge of rust-lang#126384 - RalfJung:is_none_or, r=workingjubilee

add tracking issue for is_none_or

This was forgotten in rust-lang#126328.

Cc rust-lang#126383
@Amanieu
Copy link
Member

Amanieu commented Jul 16, 2024

This hasn't been on nightly long, but it's extremely useful to have since it can make code much more readable than using is_some_and with inverted conditions, as shown in #126328 (review).

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jul 16, 2024

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 16, 2024
@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 6, 2024
@rfcbot
Copy link

rfcbot commented Aug 6, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 16, 2024
@rfcbot
Copy link

rfcbot commented Aug 16, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@bors bors closed this as completed in 9d57e46 Aug 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 16, 2024
Rollup merge of rust-lang#129086 - slanterns:is_none_or, r=dtolnay

Stabilize `is_none_or`

Closes: rust-lang#126383.

`@rustbot` label: +T-libs-api

r? libs-api
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Aug 17, 2024
Stabilize `is_none_or`

Closes: rust-lang/rust#126383.

`@rustbot` label: +T-libs-api

r? libs-api
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Aug 22, 2024
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Aug 29, 2024
Stabilize `is_none_or`

Closes: rust-lang/rust#126383.

`@rustbot` label: +T-libs-api

r? libs-api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants