Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: expected one of !, (, +, ::, <, >, or as, found : #128895

Closed
BoxyUwU opened this issue Aug 9, 2024 · 3 comments
Closed

regression: expected one of !, (, +, ::, <, >, or as, found : #128895

BoxyUwU opened this issue Aug 9, 2024 · 3 comments
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 9, 2024

[INFO] [stdout] error: expected one of `!`, `(`, `+`, `::`, `<`, `>`, or `as`, found `:`
[INFO] [stdout]   --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/comparable-0.5.4/src/tuple.rs:8:9
[INFO] [stdout]    |
[INFO] [stdout] 8  |         comparable_helper::impl_comparable_for_tuple!(($b,$($a),+));
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected one of 7 possible tokens
[INFO] [stdout] ...
[INFO] [stdout] 13 | impl_all!(A1, A2, A3, A4, A5, A6, A7, A8, A9, A10, A11, A12);
[INFO] [stdout]    | ------------------------------------------------------------ in this macro invocation
[INFO] [stdout]    |
[INFO] [stdout]    = note: this error originates in the macro `comparable_helper::impl_comparable_for_tuple` which comes from the expansion of the macro `impl_all` (in Nightly builds, run with -Z macro-backtrace for more info)
@BoxyUwU BoxyUwU added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Aug 9, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 9, 2024
@BoxyUwU BoxyUwU removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 9, 2024
@compiler-errors
Copy link
Member

compiler-errors commented Aug 9, 2024

This regressed in #127636, cc @nnethercote

nnethercote added a commit to nnethercote/rust that referenced this issue Aug 12, 2024
The special case was failing to handle invisible delimiters on one path.

Fixes rust-lang#128895.
@apiraino
Copy link
Contributor

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-high

@rustbot rustbot added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Aug 12, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Aug 12, 2024
…more, r=compiler-errors

Fix bug in `Parser::look_ahead`.

The special case was failing to handle invisible delimiters on one path.

Fixes (but doesn't close until beta backported) rust-lang#128895.

r? `@davidtwco`
@bors bors closed this as completed in 46b4c5a Aug 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 12, 2024
Rollup merge of rust-lang#128994 - nnethercote:fix-Parser-look_ahead-more, r=compiler-errors

Fix bug in `Parser::look_ahead`.

The special case was failing to handle invisible delimiters on one path.

Fixes (but doesn't close until beta backported) rust-lang#128895.

r? `@davidtwco`
cuviper pushed a commit to cuviper/rust that referenced this issue Aug 15, 2024
The special case was failing to handle invisible delimiters on one path.

Fixes rust-lang#128895.

(cherry picked from commit 46b4c5a)
@apiraino
Copy link
Contributor

hope it's ok to close this as the beta backport of #128994 was approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants