Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for reexported types missing all impls #13091

Closed
sfackler opened this issue Mar 22, 2014 · 0 comments · Fixed by #13173
Closed

Documentation for reexported types missing all impls #13091

sfackler opened this issue Mar 22, 2014 · 0 comments · Fixed by #13173
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

This includes both raw impl blocks an trait impl blocks. For example: http://static.rust-lang.org/doc/master/std/io/struct.BufferedReader.html
This was referenced Mar 23, 2014
Closed
Merged
@bors bors closed this as completed in 7e987c3 Mar 28, 2014
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Sep 13, 2022
@bors
Auto merge of rust-lang#13091 - ice1k:hey, r=Veykril
a1c2653 
Remove type alias definition on inline

Fix rust-lang#13079
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 5, 2024
@bors
Auto merge of rust-lang#13091 - Alexendoo:empty-line-after-rewrite, r…
ebcd6bc 
…=dswij

Rewrite `empty_line_after_doc_comments` and `empty_line_after_outer_attr`, move them from `nursery` to `suspicious`

changelog: [`empty_line_after_doc_comments`], [`empty_line_after_outer_attr`]: rewrite and move them from `nursery` to `suspicious`

They now lint when there's a comment between the last attr/doc comment and the empty line, to cover the case:

```rust
/// Docs for `old_code
// fn old_code() {}

fn new_code() {}
```

When these lints or `suspicious_doc_comments` trigger we no longer trigger any other doc lint as a broad fix for rust-lang#12917, reverts some of rust-lang#13002 as the empty line lints cover it

I ended up not doing rust-lang/rust-clippy#12917 (comment) as I don't think it's needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Modules are either public, or private, so private modules should... alexcrichton/rust
1 participant
@sfackler