Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aux-build tests/crashes tests don't seem to work #133009

Closed
BoxyUwU opened this issue Nov 13, 2024 · 2 comments · Fixed by #133013
Closed

aux-build tests/crashes tests don't seem to work #133009

BoxyUwU opened this issue Nov 13, 2024 · 2 comments · Fixed by #133013
Labels
A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Nov 13, 2024

cc @jieyouxu

Is it possible to write a tests/crashes test with aux-build? @camelid tried in #131081 but tidy complains that crashes/auxiliary/aux123456.rs doesnt have a known-bug annotation/
@BoxyUwU BoxyUwU added A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 13, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 13, 2024
@jieyouxu jieyouxu added C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 13, 2024
@jieyouxu jieyouxu self-assigned this Nov 13, 2024
@matthiaskrgr
Copy link
Member

Ah yes, right now it simply checks every single file as I didn't have aux tests in mind 😅

Guess we can just ignore everything in crashes/auxiliary when checking for the bug number..?

@jieyouxu
Copy link
Member

Probably a path suffix match, aux build logic expects aux file to be under an auxiliary/ folder.

@matthiaskrgr matthiaskrgr mentioned this issue Nov 13, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 14, 2024
@GuillaumeGomez
Rollup merge of rust-lang#133013 - matthiaskrgr:crash_aux, r=onur-ozkan
6a783a4 
compiletest: known-bug / crashes: allow for an "auxiliary" directory to contain files that do not have a "known-bug" directive

Fixes rust-lang#133009

r? `@jieyouxu`
@bors bors closed this as completed in 73c6494 Nov 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 14, 2024
@rust-timer
Unrolled build for rust-lang#133013
672532e 
Rollup merge of rust-lang#133013 - matthiaskrgr:crash_aux, r=onur-ozkan

compiletest: known-bug / crashes: allow for an "auxiliary" directory to contain files that do not have a "known-bug" directive

Fixes rust-lang#133009

r? `@jieyouxu`
@jieyouxu jieyouxu removed their assignment Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Done
Milestone
No milestone
4 participants
@matthiaskrgr @BoxyUwU @jieyouxu @rustbot