Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path::dirname should return Path instead of [u8] #14049

Closed
carllerche opened this issue May 8, 2014 · 2 comments · Fixed by #21759
Closed

Path::dirname should return Path instead of [u8] #14049

carllerche opened this issue May 8, 2014 · 2 comments · Fixed by #21759

Comments

@carllerche
Copy link
Member

The manipulation fns on Path should remain Path types in general.
@aturon aturon mentioned this issue Nov 6, 2014
Closed
10 tasks
@lilyball
Copy link
Contributor

lilyball commented Nov 7, 2014

We already have dir_path() which returns a Path. Is there some reason for dirname() to not exist?

@steveklabnik
Copy link
Member

This was addressed in rust-lang/rfcs#474, as @kballard points out.

@aturon aturon mentioned this issue Jan 29, 2015
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 4, 2015
@alexcrichton
rollup merge of rust-lang#21759: aturon/new-path
8550bf7 
This PR implements [path reform](rust-lang/rfcs#474), and motivation and details for the change can be found there.

For convenience, the old path API is being kept as `old_path` for the time being. Updating after this PR is just a matter of changing imports to `old_path` (which is likely not needed, since the prelude entries still export the old path API).

This initial PR does not include additional normalization or platform-specific path extensions. These will be done in follow up commits or PRs.

[breaking-change]

Closes rust-lang#20034
Closes rust-lang#12056
Closes rust-lang#11594
Closes rust-lang#14028
Closes rust-lang#14049
Closes rust-lang#10035
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 13, 2023
@bors
Auto merge of rust-lang#14049 - lnicola:flatpak, r=lnicola
04850a1 
internal: Add a manual section for Flatpak

Fixes rust-lang#14042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename std::path to std::old_path; introduce new std::path aturon/rust
3 participants
@lilyball @carllerche @steveklabnik