Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc landing page and the 404 page could have the library search box #14572

Closed
huonw opened this issue May 31, 2014 · 10 comments
Closed

Doc landing page and the 404 page could have the library search box #14572

huonw opened this issue May 31, 2014 · 10 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@huonw
Copy link
Member

huonw commented May 31, 2014

http://doc.rust-lang.org/master/ and http://doc.rust-lang.org/master/doesntexist could hook into the javascript that runs the search on http://doc.rust-lang.org/master/std/ to all show a search box themselves.

(The 404 page could even be intelligently auto-filled based on the URL, as an additional enhancement.)
@huonw huonw added the A-docs label May 31, 2014
@richo
Copy link
Contributor

richo commented May 31, 2014

This was originally my plan for it, but the javascript search thing is pretty strongly tied to the rustdoc output for a given crate.

@huonw
Copy link
Member Author

huonw commented May 31, 2014

@richo the search index is now global, all crates are in the one file.

@steveklabnik
Copy link
Member

👍

@richo
Copy link
Contributor

richo commented Jun 1, 2014

Amazing! I can probably get this out tonight.
On 31/05/2014 4:47 pm, "Huon Wilson" notifications@github.com wrote:

@richo https://github.com/richo the search index
http://doc.rust-lang.org/master/search-index.js is now global, all
crates are in the one file.

—
Reply to this email directly or view it on GitHub
#14572 (comment).

@steveklabnik
Copy link
Member

@richo did anything come of this?

@richo
Copy link
Contributor

richo commented Jun 23, 2014

Not yet, I ended up deep in frontend hell. It's on my list but not a
priority.

On Mon, Jun 23, 2014 at 10:19 AM, Steve Klabnik notifications@github.com
wrote:

@richo https://github.com/richo did anything come of this?

—
Reply to this email directly or view it on GitHub
#14572 (comment).

@huonw huonw mentioned this issue Oct 25, 2014
Closed
@seanjensengrey seanjensengrey mentioned this issue Oct 31, 2014
Closed
@steveklabnik steveklabnik mentioned this issue Jan 27, 2015
Closed
@frewsxcv
Copy link
Member

frewsxcv commented Feb 3, 2015

Triage: Just checked and the "Doc landing page and the 404 page" still don't utilize the library search box

@steveklabnik steveklabnik added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed A-docs labels Mar 8, 2015
@steveklabnik
Copy link
Member

triage: re-tagging as 'rustdoc', since we'd need it to be able to do this before adding to the docs

@steveklabnik
Copy link
Member

Triage: no change

@steveklabnik steveklabnik added T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed T-tools labels May 18, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 21, 2017
@QuietMisdreavus QuietMisdreavus mentioned this issue Aug 7, 2017
Open
@kzys
Copy link
Contributor

kzys commented Sep 13, 2018

It is possible to have a small form on https://doc.rust-lang.org/ which goes to https://doc.rust-lang.org/std/?search=vec. However the landing page is not generated by rustdoc afaik.

kzys added a commit to kzys/rust that referenced this issue Sep 15, 2018
@kzys
Add a small search box to seach Rust's standary library
d63fd46 
This change partially addresses rust-lang#14572. No CSS doesn't look fancy
but at least it is functional.
@kzys kzys mentioned this issue Sep 15, 2018
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 16, 2018
@GuillaumeGomez
Rollup merge of rust-lang#54244 - kzys:search-box, r=GuillaumeGomez
8b1e5e1 
Add a small search box to seach Rust's standary library

This change partially addresses rust-lang#14572. No CSS doesn't look fancy
but at least it is functional.
kzys added a commit to kzys/rust that referenced this issue Sep 27, 2018
@kzys
Add the library search box on the 404 page
f34805a 
It actually has a link to search already, but it would be better to
have the search "box" as like index.md to be consistent.

<style> can be shared with index.md, but these pages currently
use https://doc.rust-lang.org/rust.css directly.

Fixes rust-lang#14572.
@kzys kzys mentioned this issue Sep 27, 2018
Merged
bors added a commit that referenced this issue Oct 8, 2018
@bors
Auto merge of #54609 - kzys:404-search, r=GuillaumeGomez
aefe9b0 
Add the library search box on the 404 page

It actually has a link to search already, but it would be better to
have the search "box" as like index.md to be consistent.

<style> can be shared with index.md, but these pages currently
use https://doc.rust-lang.org/rust.css directly.

Fixes #14572.
bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
@bors
Auto merge of rust-lang#14572 - Veykril:proc-macro-close-span, r=Veykril
c479804 
Encode closing delimiter span in FlatTrees

Mainly serves as a test for the api versioning, as I don't think we make use of the closing span yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kzys @steveklabnik @frewsxcv @richo @huonw @Mark-Simulacrum