Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searches including trait methods link to invalid anchors #15169

Closed
colemickens opened this issue Jun 25, 2014 · 2 comments
Closed

Searches including trait methods link to invalid anchors #15169

colemickens opened this issue Jun 25, 2014 · 2 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@colemickens
Copy link
Contributor

For example: http://doc.rust-lang.org/collections/?search=into_ascii_lower
includes a link to: http://doc.rust-lang.org/collections/string/struct.String.html#method.into_ascii_lower

Even though that anchor isn't present on that page. It is, however, on: http://doc.rust-lang.org/std/string/struct.String.html

@huonw asked me to file this as a bug; I'm not sure how to describe the exact bug: if it is that collections::string::String appears in the results, that it's missing on the collections::string::String page, and/or that std::string::String should be in the results.

@frewsxcv
Copy link
Member

@colemickens Can you still replicate this issue?

@alexcrichton
Copy link
Member

I believe this was fixed in the interim as methods in the "Trait Implementations" section now all have anchors!

alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 8, 2015
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 17, 2023
… r=HKalbasi

Use anonymous lifetime where possible

Because anonymous lifetimes are *super* cool.

More seriously, I believe anonymous lifetimes, especially those in impl headers, reduce cognitive load to a certain extent because they usually signify that they are not relevant in the signature of the methods within (or that we can apply the usual lifetime elision rules even if they are relevant).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants