Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check fails #16305

Closed
Zoxc opened this issue Aug 6, 2014 · 6 comments
Closed

make check fails #16305

Zoxc opened this issue Aug 6, 2014 · 6 comments

Comments

@Zoxc
Copy link
Contributor

Zoxc commented Aug 6, 2014

On 84782c4

rustc: x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/libgreen
rustc: x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/lib/librustuv
maketest: bootstrap-from-c-with-green
----- /home/john/dev/rust/src/test/run-make/bootstrap-from-c-with-green/ --------------------
------ stdout ---------------------------------------------
make[1]: Entering directory '/home/john/dev/rust/src/test/run-make/bootstrap-from-c-with-green'
LD_LIBRARY_PATH="/home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green:/home/john/dev/rust/x86_64-unknown-linux-gnu/stage2/lib:" /home/john/dev/rust/x86_64-unknown-linux-gnu/stage2/bin/rustc --out-dir /home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green -L /home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green lib.rs
ccache gcc -Wall -Werror -g -fPIC -m64 -L /home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green main.c -o /home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green/main -Wl,-rpath-link=/home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green/../../../stage2/lib -lboot
Makefile:8: recipe for target 'all' failed
make[1]: Leaving directory '/home/john/dev/rust/src/test/run-make/bootstrap-from-c-with-green'

------ stderr ---------------------------------------------
/usr/bin/ld: warning: librustuv-4e7c5e5c.so, needed by /home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green/libboot.so, not found (try using -rpath or -rpath-link)
/usr/bin/ld: warning: libgreen-4e7c5e5c.so, needed by /home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green/libboot.so, not found (try using -rpath or -rpath-link)
/home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green/libboot.so: undefined reference to `start::h96683e1c0bd063fcSGc'
/home/john/dev/rust/x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green/libboot.so: undefined reference to `event_loop::h68b7d85540085d63Lhg'
collect2: error: ld returned 1 exit status
make[1]: *** [all] Error 1

------        ---------------------------------------------

/home/john/dev/rust/mk/tests.mk:1010: recipe for target 'x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green-2-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu.ok' failed
make: *** [x86_64-unknown-linux-gnu/test/run-make/bootstrap-from-c-with-green-2-T-x86_64-unknown-linux-gnu-H-x86_64-unknown-linux-gnu.ok] Error 2
make: *** Waiting for unfinished jobs....
@Zoxc
Copy link
Contributor Author

Zoxc commented Sep 1, 2014

This may have been me trying to do make check -j4.

@wizeman
Copy link
Contributor

wizeman commented Sep 28, 2014

I've ran into exactly the same problem with make check -j4.
make check works for me.

This is kind of annoying because when I want to build with make -j4, my package manager by default also builds with make check -j4.

wizeman added a commit to wizeman/nixpkgs that referenced this issue Sep 30, 2014
We also need to disable parallel building due to rust-lang/rust#16305.
Fuuzetsu pushed a commit to Fuuzetsu/nixpkgs that referenced this issue Oct 1, 2014
We also need to disable parallel building due to rust-lang/rust#16305.

Closes NixOS#4339
bors added a commit that referenced this issue Oct 24, 2014
This installs signal handlers to print out stack overflow messages on Linux. It also ensures the main thread has a guard page.

This will catch stack overflows in external code. It's done in preparation of switching to stack probes (#16012).

I've done some simple tests with overflowing the main thread, native threads and green threads (with and without UV) on x86-64.
This might work on ARM, MIPS and x86-32.

I've been unable to run the test suite on this because of #16305.
@steveklabnik
Copy link
Member

Given that this is related to green threads, I'm unsure if it should stay open, since those are gone. Thoughts?

@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 27, 2015

I think this has more to do with the -j4 part when running make check.

@wizeman
Copy link
Contributor

wizeman commented Mar 16, 2015

@steveklabnik I used to run into this bug frequently but lately I haven't had any problems running make check -j4, so I'd be in favor of closing it.

@steveklabnik
Copy link
Member

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants