Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move std::ascii into core and/or collections #16801

Closed
kmcallister opened this issue Aug 27, 2014 · 6 comments
Closed

Move std::ascii into core and/or collections #16801

kmcallister opened this issue Aug 27, 2014 · 6 comments

Comments

@kmcallister
Copy link
Contributor

I'd like to use it from a #![no_std] crate.

@kmcallister kmcallister changed the title Move std::ascii into core / collections Move std::ascii into core and/or collections Aug 27, 2014
@alexcrichton
Copy link
Member

cc #16355

The most relevant part is @aturon's concerns here: #16355 (comment).

At this time we are not sure that we'd like to do this.

@aturon
Copy link
Member

aturon commented Aug 27, 2014

@kmcallister I'd be interested to get a bit more detail on the specific functionality you're wanting to use from the ascii module.

kmcallister added a commit to servo/html5ever that referenced this issue Aug 28, 2014
When it moves into core and/or collections, we can drop some of this code.

See rust-lang/rust#16801.
@kmcallister
Copy link
Contributor Author

Okay; you can see here which parts of ascii.rs I copied in to my project. I basically need case conversion and case-insensitive comparison, as well as basic character properties (alphanum, lower case).

The HTML syntax spec is written in terms of ASCII case, and I want my implementation to be usable from C, so I'd rather not link libstd.

@alexcrichton
Copy link
Member

I think that some of the more useful aspects of std::ascii relate to how it operates over vectors and strings, not just chars and slices, so I would suspect that may belong more in collections than core, but it may want to still be scrutinized beforehand.

@frewsxcv
Copy link
Member

frewsxcv commented Jul 1, 2015

There is a third party crate for ascii available here:

https://github.com/SimonSapin/rust-ascii

This can probably be closed

@steveklabnik
Copy link
Member

agreed!

lnicola pushed a commit to lnicola/rust that referenced this issue Apr 7, 2024
fix: silence mismatches involving unresolved projections

fix rust-lang#16801
lnicola pushed a commit to lnicola/rust that referenced this issue Apr 20, 2024
fix: silence mismatches involving unresolved projections

fix rust-lang#16801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants